linux-kernel - Re: [PATCH v2 1/2] workqueue: new struct io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoQtef_6xfd4FAwe@slm.duckdns.org>
Date: Tue, 2 Jul 2024 06:40:25 -1000
From: Tejun Heo <tj@...nel.org>
To: yi sun <sunyibuaa@...il.com>
Cc: Kent Overstreet <kent.overstreet@...ux.dev>, Yi Sun <yi.sun@...soc.com>,
	jiangshanlai@...il.com, jaegeuk@...nel.org, chao@...nel.org,
	ebiggers@...gle.com, linux-f2fs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, niuzhiguo84@...il.com,
	Hao_hao.Wang@...soc.com, yunlongxing23@...il.com
Subject: Re: [PATCH v2 1/2] workqueue: new struct io_work

Hello,

On Tue, Jul 02, 2024 at 05:27:19PM +0800, yi sun wrote:
> Yes, adding the io priority attribute to work will bring huge benefits in the
> following scenarios:
> The system has huge IO pressure (these IOs may all be low-priority IOs),
> and a work (we hope to complete quickly) is also doing IO. If this work
> does not set IO priority, it will be blocked because it is difficult to get IO
> resources. And if this work sets a high IO priority and passes the IO priority
> to kworker, then this work will be completed quickly (as we expect).

As I wrote previously, you can still get trapped in a pretty bad priority
inversion whether from workqueue concurrency or queue depth exhaustion. I'm
sure that there's some spectrum of contention conditions that can be helped
with just setting ioprio, but it's a pretty partial solution.

Thanks.

-- 
tejun