linux-kernel - Re: [PATCH v9 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K DPI administrative driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024070333-matchless-batch-57ec@gregkh>
Date: Wed, 3 Jul 2024 16:33:27 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Vamsi Attunuru <vattunuru@...vell.com>
Cc: arnd@...db.de, jerinj@...vell.com, schalla@...vell.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K DPI
 administrative driver

On Wed, Jun 19, 2024 at 06:21:09AM -0700, Vamsi Attunuru wrote:
> +struct dpi_mps_mrrs_cfg {
> +	__u16 max_read_req_sz; /* Max read request size */
> +	__u16 max_payload_sz;  /* Max payload size */
> +	__u16 port; /* Ebus port */
> +	__u16 rsvd; /* Reserved */

Please spell out "reserved" you have plenty of characters to use.

Anyway, you NEVER check this, so you just made it so it can never be
used.  Please read the documentation in the kernel for how to add new
ioctls, it goes through the reasoning why you must check this for 0 now.

thanks,

greg k-h