linux-kernel - Re: [PATCH 2/3] modpost: .meminit.* is not in init section when CONFIG_MEMORY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAS+TgSo6CCrvKQ=n8=pFPDTJ3wq2chq1-p9KgSSv=N9Ww@mail.gmail.com>
Date: Wed, 3 Jul 2024 23:49:40 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Wei Yang <richard.weiyang@...il.com>, nathan@...nel.org, nicolas@...sle.eu, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	linux-kbuild@...r.kernel.org, Mike Rapoport <rppt@...nel.org>
Subject: Re: [PATCH 2/3] modpost: .meminit.* is not in init section when
 CONFIG_MEMORY_HOTPLUG set

On Wed, Jul 3, 2024 at 10:52 AM Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> On Tue,  2 Jul 2024 23:40:07 +0000 Wei Yang <richard.weiyang@...il.com> wrote:
>
> > .meminit.* is not put into init section when CONFIG_MEMORY_HOTPLUG is
> > set, since we define MEM_KEEP()/MEM_DISCARD() according to
> > CONFIG_MEMORY_HOTPLUG.
>
> Please describe how this changes modpost behaviour.
>
> Something like: "we're currently not checking for references into
> meminit and meminitdata when CONFIG_HOTPLUG=y, which may cause us to
> fail to notice incorrect references.".  But I don't think that's
> correct.  So what *is* wrong with the current code?
>


Sigh.

If you do not understand, you should not apply it.

I am surprised that there exists a person who
attempted to apply this.



-- 
Best Regards
Masahiro Yamada