linux-kernel - Re: [PATCH] dt-bindings: hwlock: sprd-hwspinlock: convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240703-cartoon-blimp-aa9640ae8c29@spud>
Date: Wed, 3 Jul 2024 16:12:22 +0100
From: Conor Dooley <conor@...nel.org>
To: Stanislav Jakubek <stano.jakubek@...il.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>, baolin.wang7@...il.com,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Orson Zhai <orsonzhai@...il.com>,
	Chunyan Zhang <zhang.lyra@...il.com>,
	linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: hwlock: sprd-hwspinlock: convert to YAML

On Wed, Jul 03, 2024 at 02:26:32PM +0200, Stanislav Jakubek wrote:
> +examples:
> +  - |
> +    #include <dt-bindings/clock/sprd,sc9860-clk.h>
> +
> +    soc {
> +      #address-cells = <2>;
> +      #size-cells = <2>;
> +
> +      hwlock@...00000 {
> +        compatible  = "sprd,hwspinlock-r3p0";

nit: double space here before the =

> +        reg = <0 0x40500000 0 0x1000>;

nit: if there's a respin, drop the 0s and use size/address cells of 1.

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)