linux-kernel - [PATCH v2] staging: iio: frequency: ad9834: Validate frequency parameter value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240703154506.25584-1-amishin@t-argos.ru>
Date: Wed, 3 Jul 2024 18:45:06 +0300
From: Aleksandr Mishin <amishin@...rgos.ru>
To: Michael Hennerich <Michael.Hennerich@...log.com>
CC: Aleksandr Mishin <amishin@...rgos.ru>, Lars-Peter Clausen
	<lars@...afoo.de>, Jonathan Cameron <jic23@...nel.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Datta Shubhrajyoti <shubhrajyoti@...com>,
	<linux-iio@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, <lvc-project@...uxtesting.org>, Dan Carpenter
	<dan.carpenter@...aro.org>
Subject: [PATCH v2] staging: iio: frequency: ad9834: Validate frequency parameter value

In ad9834_write_frequency() clk_get_rate() can return 0. In such case
ad9834_calc_freqreg() call will lead to division by zero. Checking
'if (fout > (clk_freq / 2))' doesn't protect in case of 'fout' is 0.
ad9834_write_frequency() is called from ad9834_write(), where fout is
taken from text buffer, which can contain any value.

Modify parameters checking.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 12b9d5bf76bf ("Staging: IIO: DDS: AD9833 / AD9834 driver")
Suggested-by: Dan Carpenter <dan.carpenter@...aro.org>
Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
---
v1->v2: Check if clk_freq == 0 directly instead of fout == 0
 as suggested by Dan

 drivers/staging/iio/frequency/ad9834.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
index a7a5cdcc6590..47e7d7e6d920 100644
--- a/drivers/staging/iio/frequency/ad9834.c
+++ b/drivers/staging/iio/frequency/ad9834.c
@@ -114,7 +114,7 @@ static int ad9834_write_frequency(struct ad9834_state *st,
 
 	clk_freq = clk_get_rate(st->mclk);
 
-	if (fout > (clk_freq / 2))
+	if (!clk_freq || fout > (clk_freq / 2))
 		return -EINVAL;
 
 	regval = ad9834_calc_freqreg(clk_freq, fout);
-- 
2.30.2