linux-kernel - Re: [PATCH] perf install: Don't propagate subdir to Documentation submake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <psbxdrh74gsqceu5xtgsuhzjxxaf3vspmgr6kjoz6bz2r6kiig@dc2qgrsk6wxv>
Date: Wed, 3 Jul 2024 17:54:00 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Nicolas Schier <n.schier@....de>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, 
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>, 
	Adrian Hunter <adrian.hunter@...el.com>, linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf install: Don't propagate subdir to Documentation
 submake

Hello Nicolas,

On Thu, May 23, 2024 at 10:06:40AM +0200, Nicolas Schier wrote:
> Explicitly reset 'subdir' variable when descending to
> tools/perf/Documentation.  Similar to commit f89fb55714b62 ("perf build:
> Don't propagate subdir to submakes for install_headers", 2023-01-02),
> calling the 'tools/perf_install' target via top-levels Makefile results
> in repeated subdir components when attempting to call the perf
> documentation installation rules:
> 
>     $ make tools/perf_install NO_LIBTRACEEVENT=1 JOBS=1
>     [...]
>     /bin/sh: 1: cd: can't cd to /data/linux/kbuild/tools/perf/tools/perf/
>     ../../scripts/Makefile.include:17: *** output directory "/data/linux/kbuild/tools/perf/tools/perf/" does not exist.  Stop.
>     make[5]: *** [Makefile.perf:1096: try-install-man] Error 2
>     make[4]: *** [Makefile.perf:264: sub-make] Error 2
>     make[3]: *** [Makefile:113: install] Error 2
>     make[2]: *** [Makefile:131: perf_install] Error 2
> 
> Resetting 'subdir' fixes the call from top-level Makefile.
> 
> Reported-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Signed-off-by: Nicolas Schier <n.schier@....de>

If it helps:

Tested-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>

Did I already thank you? If not: Thanks a lot!

Best regards
Uwe


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)