linux-kernel - Re: [PATCH] ASoC: amd: Adjust error handling in case of absent codec device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d37b9cb-f442-4925-a63f-e25dcfb388fe@sirena.org.uk>
Date: Wed, 3 Jul 2024 17:50:43 +0100
From: Mark Brown <broonie@...nel.org>
To: Aleksandr Mishin <amishin@...rgos.ru>
Cc: Vijendar Mukunda <Vijendar.Mukunda@....com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] ASoC: amd: Adjust error handling in case of absent codec
 device

On Wed, Jul 03, 2024 at 07:40:28PM +0300, Aleksandr Mishin wrote:
> acpi_get_first_physical_node() can return NULL in several cases (no such
> device, ACPI table error, reference count drop to 0, etc).
> Existing check just emit error message, but doesn't perform return.
> 
> Adjust this error handling by adding error code return.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

I am not seeing any analysis here about the correctness of this new
error handling.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)