linux-kernel - Re: [PATCH] cxl/acpi: simplify returning pointer without cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoWCjAHSOKQLDkF2@aschofie-mobl2>
Date: Wed, 3 Jul 2024 09:55:40 -0700
From: Alison Schofield <alison.schofield@...el.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Davidlohr Bueso <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxl/acpi: simplify returning pointer without cleanup

On Wed, Jul 03, 2024 at 10:30:55AM +0200, Krzysztof Kozlowski wrote:
> Use 'return_ptr' helper for returning a pointer without cleanup for
> shorter code.
> 

My first thought on this was that I prefer the explicitness
of pairing __free(kfree) with no_free_ptr as was done here.

cleanup.h defines this: 
#define return_ptr(p)   return no_free_ptr(p)

I did read the comments and am still confused. I see you posted a
handful of no_free_ptr to return_ptr patches. What is your selection
process for changing these?

--Alison


> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/cxl/acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> index 571069863c62..1e4bed8a933e 100644
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -339,7 +339,7 @@ static struct resource *alloc_cxl_resource(resource_size_t base,
>  	if (!res->name)
>  		return NULL;
>  
> -	return no_free_ptr(res);
> +	return_ptr(res);
>  }
>  
>  static int add_or_reset_cxl_resource(struct resource *parent, struct resource *res)
> -- 
> 2.43.0
>