linux-kernel - Re: [PATCH] crypto: mxs-dcp: Ensure payload is zero when using key slot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D2G2S9CL9VNY.3VH73LVAT90SK@kernel.org>
Date: Wed, 03 Jul 2024 20:21:22 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "David Gstir" <david@...ma-star.at>, "Herbert Xu"
 <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>,
 "Shawn Guo" <shawnguo@...nel.org>, "Sascha Hauer" <s.hauer@...gutronix.de>,
 "Fabio Estevam" <festevam@...il.com>, "David Oberhollenzer"
 <david.oberhollenzer@...ma-star.at>, "Richard Weinberger" <richard@....at>
Cc: "Pengutronix Kernel Team" <kernel@...gutronix.de>,
 <linux-crypto@...r.kernel.org>, <imx@...ts.linux.dev>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
 "sigma star Kernel Team" <upstream+dcp@...ma-star.at>, "kernel test robot"
 <lkp@...el.com>, "Dan Carpenter" <dan.carpenter@...aro.org>
Subject: Re: [PATCH] crypto: mxs-dcp: Ensure payload is zero when using key
 slot

On Wed Jul 3, 2024 at 3:49 PM EEST, David Gstir wrote:
> We could leak stack memory through the payload field when running
> AES with a key from one of the hardware's key slots. Fix this by
> ensuring the payload field is set to 0 in such cases.
>
> This does not affect the common use case when the key is supplied
> from main memory via the descriptor payload.
>
> Signed-off-by: David Gstir <david@...ma-star.at>
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/r/202405270146.Y9tPoil8-lkp@intel.com/
> Fixes: 3d16af0b4cfa ("crypto: mxs-dcp: Add support for hardware-bound keys")
> ---
>  drivers/crypto/mxs-dcp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c
> index 057d73c370b7..c82775dbb557 100644
> --- a/drivers/crypto/mxs-dcp.c
> +++ b/drivers/crypto/mxs-dcp.c
> @@ -225,7 +225,8 @@ static int mxs_dcp_start_dma(struct dcp_async_ctx *actx)
>  static int mxs_dcp_run_aes(struct dcp_async_ctx *actx,
>  			   struct skcipher_request *req, int init)
>  {
> -	dma_addr_t key_phys, src_phys, dst_phys;
> +	dma_addr_t key_phys = 0;
> +	dma_addr_t src_phys, dst_phys;
>  	struct dcp *sdcp = global_sdcp;
>  	struct dcp_dma_desc *desc = &sdcp->coh->desc[actx->chan];
>  	struct dcp_aes_req_ctx *rctx = skcipher_request_ctx(req);

I'm on holiday up until week 31 so might be that review will take
up to then.

BR, Jarkko