linux-kernel - Re: [PATCH v2] net: ethernet: mtk_ppe: Change PPE entries number to 16K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3P286MB26119C0A14621AD8D411466A98DD2@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
Date: Thu, 4 Jul 2024 01:38:50 +0800
From: Shengyu Qu <wiagn233@...look.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: wiagn233@...look.com, nbd@....name, sean.wang@...iatek.com,
 Mark-MC.Lee@...iatek.com, lorenzo@...nel.org, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, matthias.bgg@...il.com,
 angelogioacchino.delregno@...labora.com, pablo@...filter.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 stable@...r.kernel.org, Elad Yifee <eladwf@...il.com>
Subject: Re: [PATCH v2] net: ethernet: mtk_ppe: Change PPE entries number to
 16K

Hi,

BT download and PCDN would create tons of connections, and might be
easily to reach the 8192 limit, one of my friend sees 50000+ links when
hosting PCDN.

Best regards,
Shengyu

在 2024/7/3 2:02, Jakub Kicinski 写道:
> On Tue, 25 Jun 2024 19:16:54 +0800 Shengyu Qu wrote:
>> MT7981,7986 and 7988 all supports 32768 PPE entries, and MT7621/MT7620
>> supports 16384 PPE entries, but only set to 8192 entries in driver. So
>> incrase max entries to 16384 instead.
>>
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Elad Yifee <eladwf@...il.com>
>> Signed-off-by: Shengyu Qu <wiagn233@...look.com>
>> Fixes: ba37b7caf1ed ("net: ethernet: mtk_eth_soc: add support for initializing the PPE")
> 
> nit: Fixes tag usually goes before the sign-offs
> 
> This doesn't strike me as a bug fix, tho. What's the user-visible
> impact? We can't utilize HW to its full abilities?

Download attachment "OpenPGP_0xE3520CC91929C8E7.asc" of type "application/pgp-keys" (6869 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)