linux-kernel - Re: [PATCH v2] selftests: mptcp: always close input's FD if opened

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c6b2b8f-93dd-42f5-9879-99e24deb5880@kernel.org>
Date: Wed, 3 Jul 2024 19:40:27 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Liu Jing <liujing@...s.chinamobile.com>
Cc: netdev@...r.kernel.org, mptcp@...ts.linux.dev,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 martineau@...nel.org, geliang@...nel.org, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, shuah@...nel.org
Subject: Re: [PATCH v2] selftests: mptcp: always close input's FD if opened

Hi Liu,

On 02/07/2024 06:05, Liu Jing wrote:
> in main_loop_s function, when the open(cfg_input, O_RDONLY) function is run,

Please see my previous message: the commit description should have lines
of maximum ~72 chars.

> the last fd is not closed if the "--cfg_repeat > 0" branch is not taken.
> 
> Fixes: 05be5e273c84("selftests: mptcp: add disconnect tests").

There should be a space after the commit ID, not dot at the end, and no
blank line between git tags ("Fixes:", "Signed-off-by", etc.).

> 
> Signed-off-by: Liu Jing <liujing@...s.chinamobile.com>
> ---
> Changes from v1
> - add close function in main_loop_s function

It looks like you didn't change the code as I suggested: moving...

  if (cfg_input)
          close(fd);

before 'if (--cfg_repeat > 0)'.

Anyway, I just applied your patch in our tree (fixes for -net) with all
the modifications mentioned above. We will send it to netdev later with
other patches.

New patches for t/upstream-net and t/upstream:
- d2657c3f784a: selftests: mptcp: always close input's FD if opened
- Results: a9e719ce2340..fa4c0289d475 (export-net)
- Results: b49e920db095..dcc28bf9bc6a (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/fa397dbd31963500c42d31a4892e0b9c7e4c9ff9/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/ff673f57b4479a78dd9eb18af3c8c0fe73bf958b/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.