linux-kernel - Re: [PATCH] dma-buf: Remove unnecessary kmalloc() cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuCfpHJPtduJwOyxTFT9RVmWZCcWULWhUN4ZPEt6earHp=MXA@mail.gmail.com>
Date: Wed, 3 Jul 2024 10:45:21 -0700
From: Suren Baghdasaryan <surenb@...gle.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Christian König <christian.koenig@....com>, 
	Christoph Hellwig <hch@....de>, Thorsten Blum <thorsten.blum@...lux.com>, jack@...e.cz, 
	linux-kernel@...r.kernel.org, Sumit Semwal <sumit.semwal@...aro.org>, 
	linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH] dma-buf: Remove unnecessary kmalloc() cast

On Tue, Jul 2, 2024 at 8:15 AM Suren Baghdasaryan <surenb@...gle.com> wrote:
>
> On Tue, Jul 2, 2024 at 7:34 AM Andrew Morton <akpm@...ux-foundation.org> wrote:
> >
> > On Tue, 2 Jul 2024 09:13:35 +0200 Christian König <christian.koenig@....com> wrote:
> >
> > > yes that is
> > > intentionally a define and not an inline function.
> > >
> > > See this patch here which changed that:
> > >
> > > commit 2c321f3f70bc284510598f712b702ce8d60c4d14
> > > Author: Suren Baghdasaryan <surenb@...gle.com>
> > > Date:   Sun Apr 14 19:07:31 2024 -0700
> > >
> > >      mm: change inlined allocation helpers to account at the call site
> >
> > Dang, yes, that was a regrettable change.  But hardly the end of the
> > world.  I do think each such alteration should have included a comment
> > to prevent people from going and cleaning them up.
>
> Sorry I missed this discussion. Yes, the definition was intentional
> and I will add comments for all the cases which were changed this way.

Posted https://lore.kernel.org/all/20240703174225.3891393-1-surenb@google.com/
adding clarifying comments.
Thanks,
Suren.

> Thanks,
> Suren.
>
> >
> >