linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: x1e80100: add Lenovo Thinkpad Yoga slim 7x devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80baa293-d0b1-404c-afc6-4e0e25ae7f60@linaro.org>
Date: Wed, 3 Jul 2024 20:39:42 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To: Rob Clark <robdclark@...il.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: x1e80100: add Lenovo Thinkpad Yoga
 slim 7x devicetree



On 03/07/2024 19:33, Rob Clark wrote:
> On Wed, Jul 3, 2024 at 10:17 AM Srinivas Kandagatla
> <srinivas.kandagatla@...aro.org> wrote:
>>
>> Add an initial devicetree for the Lenovo Yoga slim 7x with support for
>> Display, usb, keyboard, touchscreen, PMICs, speaker audio, gpu, NVMe,
>> and remoteprocs.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/Makefile                  |   1 +
>>   .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  | 910 +++++++++++++++++++++
>>   2 files changed, 911 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index e0babd642fa8..d7de2aea4748 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -261,4 +261,5 @@ dtb-$(CONFIG_ARCH_QCOM)     += sm8650-mtp.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)        += sm8650-qrd.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)        += x1e80100-asus-vivobook-s15.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)        += x1e80100-crd.dtb
>> +dtb-$(CONFIG_ARCH_QCOM)        += x1e80100-lenovo-yoga-slim7x.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)        += x1e80100-qcp.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
>> new file mode 100644
>> index 000000000000..1d00119691bc
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
>> @@ -0,0 +1,910 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
...
>> +
>> +&gpu {
>> +       status = "okay";
>> +
>> +       zap-shader {
>> +               firmware-name = "qcom/x1e80100/LENOVO/14Q8X9/qcdxkmsuc8380.mbn";
> 
> I ended up with:
> 
>    firmware-name = "qcom/x1e80100/LENOVO/83ED/qcdxkmsuc8380.mbn";
> 
> my DMI string is:
> 
>    DMI: LENOVO 83ED/LNVNB161216, BIOS NHCN36WW 05/23/2024
> 
> idk if that is different for you?


You are correct, dmi/id/product_name is 83ED in my case too. I think i 
overlooked it :-)


will send out a v2 to fix this one..


> 
>> +       };
>> +};
>> +
>> +&i2c0 {
>> +       clock-frequency = <400000>;
>> +
>> +       status = "okay";
>> +
> 
> I also have this, which is working for me (sry about gmail butchering
> the formating):
> 
> 
> touchpad@2c {
> compatible = "hid-over-i2c";
> reg = <0x2c>;
> 
> hid-descr-addr = <0x20>;
> interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
> 
> pinctrl-0 = <&tpad_default>;
> pinctrl-names = "default";
> 
> wakeup-source;
> };
> 
> basically just uncommented the node from Xilin's tree, but seems to work fine.
> 

Thanks.. I could not figure out the descr-addr from acpi tables.
It works now..
V2 will have this as well.

--srini

> BR,
> -R
>