linux-kernel - Re: [PATCH] dm-verity: fix dm_is_verity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202407031326.8DD8F504@keescook>
Date: Wed, 3 Jul 2024 13:26:17 -0700
From: Kees Cook <kees@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: dm-devel@...ts.linux.dev, Alasdair Kergon <agk@...hat.com>,
	Mike Snitzer <snitzer@...nel.org>,
	Mikulas Patocka <mpatocka@...hat.com>,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Matthias Kaehlcke <mka@...omium.org>
Subject: Re: [PATCH] dm-verity: fix dm_is_verity_target() when dm-verity is
 builtin

On Wed, Jul 03, 2024 at 01:08:13PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> When CONFIG_DM_VERITY=y, dm_is_verity_target() returned true for any
> builtin dm target, not just dm-verity.  Fix this by checking for
> verity_target instead of THIS_MODULE (which is NULL for builtin code).
> 
> Fixes: b6c1c5745ccc ("dm: Add verity helpers for LoadPin")
> Cc: stable@...r.kernel.org
> Cc: Matthias Kaehlcke <mka@...omium.org>
> Cc: Kees Cook <keescook@...omium.org>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Ah! Nice catch.

Reviewed-by: Kees Cook <kees@...nel.org>

-- 
Kees Cook