linux-kernel - Re: [RFC PATCH] i2c: rcar: bring hardware to known state when probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <g6mthbu3bbg2vl3aobci2gx7lbfy4qbiy7cy43v7wwgjldauc3@qv4yrctu2bmf>
Date: Wed, 3 Jul 2024 22:27:12 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-renesas-soc@...r.kernel.org, 
	Dirk Behme <dirk.behme@...bosch.com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] i2c: rcar: bring hardware to known state when probing

Hi Wolfram,

On Wed, Jul 03, 2024 at 09:12:03AM GMT, Wolfram Sang wrote:
> Probably due to a lot of refactorization, the hardware was not brought
> into a known state in probe. This may be a problem when a hypervisor
> restarts Linux without resetting the hardware, leaving an old state
> running. Make sure the hardware gets initialized, especially interrupts
> should be cleared and disabled.
> 
> Reported-by: Dirk Behme <dirk.behme@...bosch.com>
> Reported-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Closes: https://lore.kernel.org/r/20240702045535.2000393-1-dirk.behme@de.bosch.com
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Do we need the Fixes tag here?

> ---
> 
> Here is my proposal to fix the issue reported by Dirk. Build tested.
> I can do proper testing on HW only tomorrow. But so you know already...

Looks reasonable. If testing is fine I can queue this up for this
week's pull request.

> It is strange to add another "_slave" function to the driver while I
> work on removing such language from I2C somewhere else. "Consistency" is
> the answer here. The driver will be converted as well. But then as a
> whole.

Ack!

Thanks,
Andi