linux-kernel - Re: [PATCH PATCH v2 9/9] x86/rfds: Exclude P-only parts from the RFDS affected list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240703220444.oufkvabpivillv3e@treble>
Date: Wed, 3 Jul 2024 15:04:44 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	daniel.sneddon@...ux.intel.com, tony.luck@...el.com,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-perf-users@...r.kernel.org,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	Brice Goglin <brice.goglin@...il.com>,
	Mario Limonciello <mario.limonciello@....com>,
	Perry Yuan <Perry.Yuan@....com>,
	Dapeng Mi <dapeng1.mi@...ux.intel.com>
Subject: Re: [PATCH PATCH v2 9/9] x86/rfds: Exclude P-only parts from the
 RFDS affected list

On Wed, Jul 03, 2024 at 11:26:13AM -0700, Pawan Gupta wrote:
> On Tue, Jul 02, 2024 at 06:04:33PM -0700, Josh Poimboeuf wrote:
> > Same comment here, these should be inline with the main list.  Maybe
> > there's some way to structure the indentations so they align better
> > vertically with the STEPPINGS/TYPE variants.
> 
> This is how it is turning out to be:
> +	VULNBL_INTEL(		IVYBRIDGE,		SRBDS),
> +	VULNBL_INTEL(		HASWELL,		SRBDS),
> +	VULNBL_INTEL(		HASWELL_L,		SRBDS),
> +	VULNBL_INTEL(		HASWELL_G,		SRBDS),
> +	VULNBL_INTEL(		HASWELL_X,		MMIO),
> +	VULNBL_INTEL(		BROADWELL_D,		MMIO),
> +	VULNBL_INTEL(		BROADWELL_G,		SRBDS),
> +	VULNBL_INTEL(		BROADWELL_X,		MMIO),
> +	VULNBL_INTEL(		BROADWELL,		SRBDS),
> +	VULNBL_INTEL(		SKYLAKE_X,		MMIO | RETBLEED | GDS),
> +	VULNBL_INTEL(		SKYLAKE_L,		MMIO | RETBLEED | GDS | SRBDS),
> +	VULNBL_INTEL(		SKYLAKE,		MMIO | RETBLEED | GDS | SRBDS),
> +	VULNBL_INTEL(		KABYLAKE_L,		MMIO | RETBLEED | GDS | SRBDS),
> +	VULNBL_INTEL(		KABYLAKE,		MMIO | RETBLEED | GDS | SRBDS),
> +	VULNBL_INTEL(		CANNONLAKE_L,		RETBLEED),
> +	VULNBL_INTEL(		ICELAKE_L,		MMIO | MMIO_SBDS | RETBLEED | GDS),
> +	VULNBL_INTEL(		ICELAKE_D,		MMIO | GDS),
> +	VULNBL_INTEL(		ICELAKE_X,		MMIO | GDS),
> +	VULNBL_INTEL(		COMETLAKE,		MMIO | MMIO_SBDS | RETBLEED | GDS),
> +	VULNBL_INTEL_STEPPINGS(	COMETLAKE_L,	X86_STEPPINGS(0x0, 0x0),	MMIO | RETBLEED),
> +	VULNBL_INTEL(		COMETLAKE_L,		MMIO | MMIO_SBDS | RETBLEED | GDS),
> +	VULNBL_INTEL(		TIGERLAKE_L,		GDS),
> +	VULNBL_INTEL(		TIGERLAKE,		GDS),
> +	VULNBL_INTEL(		LAKEFIELD,		MMIO | MMIO_SBDS | RETBLEED),
> +	VULNBL_INTEL(		ROCKETLAKE,		MMIO | RETBLEED | GDS),
> +	VULNBL_INTEL_TYPE(	ALDERLAKE,	ATOM,	RFDS),
> +	VULNBL_INTEL(		ALDERLAKE_L,		RFDS),
> +	VULNBL_INTEL_TYPE(	RAPTORLAKE,	ATOM,	RFDS),
> +	VULNBL_INTEL(		RAPTORLAKE_P,		RFDS),
> +	VULNBL_INTEL(		RAPTORLAKE_S,		RFDS),
> +	VULNBL_INTEL(		ATOM_GRACEMONT,		RFDS),
> +	VULNBL_INTEL(		ATOM_TREMONT,		MMIO | MMIO_SBDS | RFDS),
> +	VULNBL_INTEL(		ATOM_TREMONT_D,		MMIO | RFDS),
> +	VULNBL_INTEL(		ATOM_TREMONT_L,		MMIO | MMIO_SBDS | RFDS),
> +	VULNBL_INTEL(		ATOM_GOLDMONT,		RFDS),
> +	VULNBL_INTEL(		ATOM_GOLDMONT_D,	RFDS),
> +	VULNBL_INTEL(		ATOM_GOLDMONT_PLUS,	RFDS),

Looks good to me.

The bug bits could also be vertically aligned, but that might offend
those with undersized terminals :-)

-- 
Josh