linux-kernel - [PATCH] spmi: pmic-arb: use correct node when adding irq domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240703221157.3640361-1-quic_collinsd@quicinc.com>
Date: Wed, 3 Jul 2024 15:11:57 -0700
From: David Collins <quic_collinsd@...cinc.com>
To: Stephen Boyd <sboyd@...nel.org>, <linux-kernel@...r.kernel.org>
CC: David Collins <quic_collinsd@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        Abel Vesa <abel.vesa@...aro.org>,
        "Dan
 Carpenter" <dan.carpenter@...aro.org>,
        Neil Armstrong
	<neil.armstrong@...aro.org>
Subject: [PATCH] spmi: pmic-arb: use correct node when adding irq domain

Pass a pointer to the SPMI bus subnode instead of the top-
level PMIC arbiter node when calling irq_domain_add_tree().
This ensures that consumer IRQ mappings can be found
successfully at runtime.

Here is an example of a consumer device probe deferral that
happens without this fix in place:

[   18.197271] platform c42d000.spmi:qcom,pmk8550@0:pon_hlos@...0:pwrkey:
  deferred probe pending: pm8941-pwrkey: IRQ index 0 not found
[   18.197275] platform c42d000.spmi:qcom,pmk8550@0:pon_hlos@...0:resin:
  deferred probe pending: pm8941-pwrkey: IRQ index 0 not found

Fixes: 02922ccbb330 ("spmi: pmic-arb: Register controller for bus instead of arbiter")
Fixes: 979987371739 ("spmi: pmic-arb: Add multi bus support")
Signed-off-by: David Collins <quic_collinsd@...cinc.com>
---
 drivers/spmi/spmi-pmic-arb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 791cdc160c51..e6a4bf3abb1f 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -1737,8 +1737,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
 
 	dev_dbg(&pdev->dev, "adding irq domain for bus %d\n", bus_index);
 
-	bus->domain = irq_domain_add_tree(dev->of_node,
-					  &pmic_arb_irq_domain_ops, bus);
+	bus->domain = irq_domain_add_tree(node, &pmic_arb_irq_domain_ops, bus);
 	if (!bus->domain) {
 		dev_err(&pdev->dev, "unable to create irq_domain\n");
 		return -ENOMEM;
-- 
2.25.1