[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZoXg_fk7HRZn89ij@google.com>
Date: Wed, 3 Jul 2024 16:38:37 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: weilin.wang@...el.com
Cc: Ian Rogers <irogers@...gle.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
Kan Liang <kan.liang@...ux.intel.com>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
Perry Taylor <perry.taylor@...el.com>,
Samantha Alt <samantha.alt@...el.com>,
Caleb Biggers <caleb.biggers@...el.com>
Subject: Re: [RFC PATCH v15 8/8] perf test: Add test for Intel TPEBS counting
mode
Hello,
On Tue, Jul 02, 2024 at 06:07:55PM -0400, weilin.wang@...el.com wrote:
> From: Weilin Wang <weilin.wang@...el.com>
>
> Intel TPEBS sampling mode is supported through perf record. The counting mode
> code uses perf record to capture retire_latency value and use it in metric
> calculation. This test checks the counting mode code.
>
> Signed-off-by: Weilin Wang <weilin.wang@...el.com>
> ---
> .../perf/tests/shell/test_stat_intel_tpebs.sh | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100755 tools/perf/tests/shell/test_stat_intel_tpebs.sh
>
> diff --git a/tools/perf/tests/shell/test_stat_intel_tpebs.sh b/tools/perf/tests/shell/test_stat_intel_tpebs.sh
> new file mode 100755
> index 000000000000..220b830eac61
> --- /dev/null
> +++ b/tools/perf/tests/shell/test_stat_intel_tpebs.sh
> @@ -0,0 +1,18 @@
> +#!/bin/bash
> +# test Intel TPEBS counting mode
> +# SPDX-License-Identifier: GPL-2.0
> +
> +set e
Probably you want 'set -e'.
> +
> +# Use this event for testing because it should exist in all platforms
> +e=cache-misses:R
Please rename it to 'event'.
> +
> +# Without this cmd option, default value or zero is returned
> +echo "Testing without --enable-tpebs-recording"
I think you need to update the option name.
> +result=$(perf stat -e "$e" true 2>&1)
> +[[ "$result" =~ $e ]] || exit 1
> +
> +# In platforms that do not support TPEBS, it should execute without error.
> +echo "Testing with --enable-tpebs-recording"
> +result=$(perf stat -e "$e" --enable-tpebs-recording -a sleep 0.01 2>&1)
Ditto.
Thanks,
Namhyung
> +[[ "$result" =~ "perf record" && "$result" =~ $e ]] || exit 1
> --
> 2.43.0
>
Powered by blists - more mailing lists