| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20240703033855.3373-5-jiangshanlai@gmail.com> Date: Wed, 3 Jul 2024 11:38:53 +0800 From: Lai Jiangshan <jiangshanlai@...il.com> To: linux-kernel@...r.kernel.org Cc: Lai Jiangshan <jiangshan.ljs@...group.com>, Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com> Subject: [PATCH 4/6] workqueue: Init rescuer before alloc and link pwqs From: Lai Jiangshan <jiangshan.ljs@...group.com> Swap the order of the allocations for rescuer and pwqs to prepare for making alloc_and_link_pwqs() and the wq enlistment into the same wq_pool_mutex and cpu hotplug locks protection. Signed-off-by: Lai Jiangshan <jiangshan.ljs@...group.com> --- kernel/workqueue.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 0dd9a12befb5..810ea55c0ac9 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -5704,11 +5704,11 @@ struct workqueue_struct *alloc_workqueue(const char *fmt, goto err_unreg_lockdep; } - if (alloc_and_link_pwqs(wq) < 0) + if (wq_online && init_rescuer(wq) < 0) goto err_free_node_nr_active; - if (wq_online && init_rescuer(wq) < 0) - goto err_destroy; + if (alloc_and_link_pwqs(wq) < 0) + goto err_free_rescuer; /* * wq_pool_mutex protects global freeze state and workqueues list. @@ -5730,6 +5730,8 @@ struct workqueue_struct *alloc_workqueue(const char *fmt, return wq; +err_free_rescuer: + destroy_rescuer(wq); err_free_node_nr_active: if (wq->flags & WQ_UNBOUND) free_node_nr_active(wq->node_nr_active); -- 2.19.1.6.gb485710b
Powered by blists - more mailing lists