[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANAwSgTfHhFwGtMMGUOpoNo7SGnVyOt87puXt1HJE3_d7OiHqw@mail.gmail.com>
Date: Wed, 3 Jul 2024 09:17:28 +0530
From: Anand Moon <linux.amoon@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, linux-usb@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, Allen Pais <allen.lkml@...il.com>
Subject: Re: [PATCH-next v1] r8152: Convert tasklet API to new bottom half
workqueue mechanism
Hi Jakub,
Thanks for this review's comments.
+ Allen Pais
On Wed, 3 Jul 2024 at 07:12, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 1 Jul 2024 15:33:27 +0530 Anand Moon wrote:
> > Migrate tasklet APIs to the new bottom half workqueue mechanism. It
> > replaces all occurrences of tasklet usage with the appropriate workqueue
> > APIs throughout the alteon driver. This transition ensures compatibility
> > with the latest design and enhances performance
>
> alteon ?
Ok copy past the committee message, I will fix this in the next patch.
This patch is just follow-up on work done by Allen Pais
[1] https://lore.kernel.org/all/20240621183947.4105278-14-allen.lkml@gmail.com/
>
> > - tasklet_enable(&tp->tx_tl);
> > + enable_and_queue_work(system_bh_wq, &tp->tx_work);
>
> This is not obviously correct. Please explain why in the commit message
> if you're sure this is right.
Ok, I will gather all the feedback and work on these changes.
And update this patch.
> --
> pw-bot: cr
Thanks
-Anand
Powered by blists - more mailing lists