linux-kernel - Re: [PATCH v1] binder: frozen notification binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024070339-clarinet-deceased-6200@gregkh>
Date: Wed, 3 Jul 2024 07:40:17 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Yu-Ting Tseng <yutingtseng@...gle.com>
Cc: cmllamas@...gle.com, tkjos@...gle.com, arve@...roid.com,
	maco@...roid.com, joel@...lfernandes.org, brauner@...nel.org,
	surenb@...gle.com, aliceryhl@...gle.com, kernel-team@...roid.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] binder: frozen notification binder_features flag

On Tue, Jul 02, 2024 at 04:04:54PM -0700, Yu-Ting Tseng wrote:
> Add a flag to binder_features to indicate that the freeze notification
> feature is available.
> ---
>  drivers/android/binderfs.c                                | 8 ++++++++
>  .../selftests/filesystems/binderfs/binderfs_test.c        | 1 +
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> index 3001d754ac36..ad1fa7abc323 100644
> --- a/drivers/android/binderfs.c
> +++ b/drivers/android/binderfs.c
> @@ -58,6 +58,7 @@ enum binderfs_stats_mode {
>  struct binder_features {
>  	bool oneway_spam_detection;
>  	bool extended_error;
> +	bool freeze_notification;
>  };
>  
>  static const struct constant_table binderfs_param_stats[] = {
> @@ -74,6 +75,7 @@ static const struct fs_parameter_spec binderfs_fs_parameters[] = {
>  static struct binder_features binder_features = {
>  	.oneway_spam_detection = true,
>  	.extended_error = true,
> +	.freeze_notification = true,
>  };
>  
>  static inline struct binderfs_info *BINDERFS_SB(const struct super_block *sb)
> @@ -608,6 +610,12 @@ static int init_binder_features(struct super_block *sb)
>  	if (IS_ERR(dentry))
>  		return PTR_ERR(dentry);
>  
> +	dentry = binderfs_create_file(dir, "freeze_notification",
> +				      &binder_features_fops,
> +				      &binder_features.freeze_notification);
> +	if (IS_ERR(dentry))
> +		return PTR_ERR(dentry);
> +
>  	return 0;
>  }
>  
> diff --git a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
> index 5f362c0fd890..319567f0fae1 100644
> --- a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
> +++ b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
> @@ -65,6 +65,7 @@ static int __do_binderfs_test(struct __test_metadata *_metadata)
>  	static const char * const binder_features[] = {
>  		"oneway_spam_detection",
>  		"extended_error",
> +		"freeze_notification",
>  	};
>  
>  	change_mountns(_metadata);
> -- 
> 2.45.2.803.g4e1b14247a-goog
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/process/submitting-patches.rst and resend
  it after adding that line.  Note, the line needs to be in the body of
  the email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot