linux-kernel - Re: [PATCH PATCH v2 9/9] x86/rfds: Exclude P-only parts from the RFDS affected list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240703010433.2ymzh5g7osth5ch5@treble>
Date: Tue, 2 Jul 2024 18:04:33 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	daniel.sneddon@...ux.intel.com, tony.luck@...el.com,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-perf-users@...r.kernel.org,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	Brice Goglin <brice.goglin@...il.com>,
	Mario Limonciello <mario.limonciello@....com>,
	Perry Yuan <Perry.Yuan@....com>,
	Dapeng Mi <dapeng1.mi@...ux.intel.com>
Subject: Re: [PATCH PATCH v2 9/9] x86/rfds: Exclude P-only parts from the
 RFDS affected list

On Thu, Jun 27, 2024 at 01:44:55PM -0700, Pawan Gupta wrote:
> @@ -1255,9 +1260,7 @@ static const struct x86_cpu_id cpu_vuln_blacklist[] __initconst = {
>  	VULNBL_INTEL(TIGERLAKE,			GDS),
>  	VULNBL_INTEL(LAKEFIELD,			MMIO | MMIO_SBDS | RETBLEED),
>  	VULNBL_INTEL(ROCKETLAKE,		MMIO | RETBLEED | GDS),
> -	VULNBL_INTEL(ALDERLAKE,			RFDS),
>  	VULNBL_INTEL(ALDERLAKE_L,		RFDS),
> -	VULNBL_INTEL(RAPTORLAKE,		RFDS),
>  	VULNBL_INTEL(RAPTORLAKE_P,		RFDS),
>  	VULNBL_INTEL(RAPTORLAKE_S,		RFDS),
>  	VULNBL_INTEL(ATOM_GRACEMONT,		RFDS),
> @@ -1271,6 +1274,8 @@ static const struct x86_cpu_id cpu_vuln_blacklist[] __initconst = {
>  	/* Match more than Vendor/Family/Model */
>  	VULNBL_INTEL_STEPPINGS(COMETLAKE_L,	X86_STEPPINGS(0x0, 0x0),	MMIO | RETBLEED),
>  	VULNBL_INTEL	      (COMETLAKE_L,					MMIO | MMIO_SBDS | RETBLEED | GDS),
> +	VULNBL_INTEL_TYPE     (ALDERLAKE,	ATOM,				RFDS),
> +	VULNBL_INTEL_TYPE     (RAPTORLAKE,	ATOM,				RFDS),

Same comment here, these should be inline with the main list.  Maybe
there's some way to structure the indentations so they align better
vertically with the STEPPINGS/TYPE variants.

-- 
Josh