linux-kernel - Re: [PATCH v3 1/2] selftests/resctrl: Adjust effective L3 cache size with SNC enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ocgoqu6hyouc37bes6drvnp2x4qvoiasz4wtckzeveeqgmxac6@e3spe5xyrvce>
Date: Wed, 3 Jul 2024 08:43:53 +0200
From: Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>
To: Reinette Chatre <reinette.chatre@...el.com>
CC: <shuah@...nel.org>, <fenghua.yu@...el.com>,
	<linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
	<ilpo.jarvinen@...ux.intel.com>, <tony.luck@...el.com>
Subject: Re: [PATCH v3 1/2] selftests/resctrl: Adjust effective L3 cache size
 with SNC enabled

On 2024-07-02 at 15:20:22 -0700, Reinette Chatre wrote:
>Hi Maciej,
>
>On 7/1/24 7:18 AM, Maciej Wieczor-Retman wrote:
>...
>> +int snc_nodes_per_l3_cache(void)
>> +{
>> +	int node_cpus, cache_cpus, i, ret = 1;
>> +
>> +	node_cpus = count_sys_bitmap_bits("/sys/devices/system/node/node0/cpumap");
>> +	cache_cpus = count_sys_bitmap_bits("/sys/devices/system/cpu/cpu0/cache/index3/shared_cpu_map");
>> +
>> +	if (!node_cpus || !cache_cpus) {
>> +		ksft_print_msg("Could not determine Sub-NUMA Cluster mode!\n");
>
>nit: could you please check this series and remove exclamation marks from the messages
>printed to user space? Just stating the error should be sufficient.

Sure, will do.

>
>Reinette

-- 
Kind regards
Maciej Wieczór-Retman