linux-kernel - Re: [PATCH 3/7] dt-bindings: gpio: vf610: Allow gpio-line-names to be set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3dda06a0-dd5b-4264-a142-562fa7bab3eb@kontron.de>
Date: Wed, 3 Jul 2024 09:43:26 +0200
From: Frieder Schrempf <frieder.schrempf@...tron.de>
To: Krzysztof Kozlowski <krzk@...nel.org>, Frieder Schrempf
 <frieder@...s.de>, Bartosz Golaszewski <brgl@...ev.pl>,
 Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
 Stefan Agner <stefan@...er.ch>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Peng Fan <peng.fan@....com>
Subject: Re: [PATCH 3/7] dt-bindings: gpio: vf610: Allow gpio-line-names to be
 set

Hi Krzysztof,

thanks for reviewing!

On 02.07.24 4:23 PM, Krzysztof Kozlowski wrote:
> On 02/07/2024 12:31, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@...tron.de>
>>
>> Describe common "gpio-line-names" property to fix dtbs_check warnings
>> like:
>>
>>   arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dtb: gpio@...10000:
> 
> There is no such file. You cannot use future work as reason for a
> warning. Simply such warning does not exist at this point and
> introducing warnings knowingly is also not correct.

Ok, I will change the commit message and not mention the warning.

> 
>>     'gpio-line-names' does not match any of the regexes: '^.+-hog(-[0-9]+)?$', 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
>> ---
>>  Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
>> index a27f929502575..7230ba1a386ae 100644
>> --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
>> @@ -50,6 +50,7 @@ properties:
>>      const: 2
>>  
>>    gpio-controller: true
>> +  gpio-line-names: true
> 
> maxItems are not known?

I will set "minItems: 1" and "maxItems: 32" as this is the proper range
for the number of values.

Thanks
Frieder