lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e2da85aa-c39c-4494-8c11-b57adb0a7ccf@suse.de>
Date: Wed, 3 Jul 2024 10:44:30 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Wu Hoi Pok <wuhoipok@...il.com>
Cc: Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 "Pan, Xinhui" <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/6] drm/radeon: use variable flags as parameter



Am 30.06.24 um 18:59 schrieb Wu Hoi Pok:
> To be consistent with amdgpu driver, use "flags" as the parameter because
> it is already assigned as "ent->driver_data".
>
> Signed-off-by: Wu Hoi Pok <wuhoipok@...il.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>
Tested-by: Thomas Zimmermann <tzimmermann@...e.de>


> ---
>   drivers/gpu/drm/radeon/radeon_drv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index 88d3de2a79f8..7b8aa8406751 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -314,7 +314,7 @@ static int radeon_pci_probe(struct pci_dev *pdev,
>   	if (ret)
>   		goto err_agp;
>   
> -	ret = drm_dev_register(ddev, ent->driver_data);
> +	ret = drm_dev_register(ddev, flags);
>   	if (ret)
>   		goto err_agp;
>   

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ