linux-kernel - Re: [PATCH] firmware: qcom: tzmem: simplify returning pointer without cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MeW2ztyYkftJBy_ac30H+w0LinR9BFAmHMdsfQXa1EgFA@mail.gmail.com>
Date: Wed, 3 Jul 2024 10:45:14 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konrad.dybcio@...aro.org>, linux-arm-msm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: qcom: tzmem: simplify returning pointer without cleanup

On Wed, Jul 3, 2024 at 10:31 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> Use 'return_ptr' helper for returning a pointer without cleanup for
> shorter code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/firmware/qcom/qcom_tzmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/qcom/qcom_tzmem.c b/drivers/firmware/qcom/qcom_tzmem.c
> index 5d526753183d..ab156ab3a6b4 100644
> --- a/drivers/firmware/qcom/qcom_tzmem.c
> +++ b/drivers/firmware/qcom/qcom_tzmem.c
> @@ -242,7 +242,7 @@ qcom_tzmem_pool_new(const struct qcom_tzmem_pool_config *config)
>                 }
>         }
>
> -       return no_free_ptr(pool);
> +       return_ptr(pool);
>  }
>  EXPORT_SYMBOL_GPL(qcom_tzmem_pool_new);
>
> --
> 2.43.0
>
>

I'm not a big fan of this one. Same with any macro affecting flow
control statements.

But since it's there and the patch is not wrong:

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>