[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <748e1bd6-6c40-443d-acbc-3d379229d068@suse.de>
Date: Wed, 3 Jul 2024 10:52:42 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Wu Hoi Pok <wuhoipok@...il.com>
Cc: Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>,
"Pan, Xinhui" <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>, amd-gfx@...ts.freedesktop.org,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/6] drm/radeon: remove load callback & drm_dev_alloc
Hi
Am 30.06.24 um 18:59 schrieb Wu Hoi Pok:
> .load and drm_dev_alloc are deprecated. These patch series aims to
> remove them.
>
> v3: Both v1 and v2 sucks. v3 improves greatly on readability.
Very nice, thank you. I tested the patches with Radeon hardware and did
not find issues. AFAICT this can be merged as-is. I think it should go
into the amd trees. Maybe Alex or Christian can pick it up.
Thanks for sticking with it.
Best regards
Thomas
>
> Wu Hoi Pok (6):
> drm/radeon: change variable name "dev" to "ddev" for consistency
> drm/radeon: remove load callback from kms_driver
> drm/radeon: use variable flags as parameter
> drm/radeon: add helper rdev_to_drm(rdev)
> drm/radeon: change rdev->ddev to rdev_to_drm(rdev)
> drm/radeon: change drm_dev_alloc to devm_drm_dev_alloc
>
> drivers/gpu/drm/radeon/atombios_encoders.c | 2 +-
> drivers/gpu/drm/radeon/cik.c | 14 ++--
> drivers/gpu/drm/radeon/dce6_afmt.c | 2 +-
> drivers/gpu/drm/radeon/evergreen.c | 12 ++--
> drivers/gpu/drm/radeon/ni.c | 2 +-
> drivers/gpu/drm/radeon/r100.c | 24 +++----
> drivers/gpu/drm/radeon/r300.c | 6 +-
> drivers/gpu/drm/radeon/r420.c | 6 +-
> drivers/gpu/drm/radeon/r520.c | 2 +-
> drivers/gpu/drm/radeon/r600.c | 12 ++--
> drivers/gpu/drm/radeon/r600_cs.c | 2 +-
> drivers/gpu/drm/radeon/r600_dpm.c | 4 +-
> drivers/gpu/drm/radeon/r600_hdmi.c | 2 +-
> drivers/gpu/drm/radeon/radeon.h | 7 +-
> drivers/gpu/drm/radeon/radeon_acpi.c | 10 +--
> drivers/gpu/drm/radeon/radeon_agp.c | 2 +-
> drivers/gpu/drm/radeon/radeon_atombios.c | 2 +-
> drivers/gpu/drm/radeon/radeon_audio.c | 4 +-
> drivers/gpu/drm/radeon/radeon_combios.c | 12 ++--
> drivers/gpu/drm/radeon/radeon_device.c | 13 ++--
> drivers/gpu/drm/radeon/radeon_display.c | 74 +++++++++++-----------
> drivers/gpu/drm/radeon/radeon_drv.c | 27 +++++---
> drivers/gpu/drm/radeon/radeon_fbdev.c | 26 ++++----
> drivers/gpu/drm/radeon/radeon_fence.c | 8 +--
> drivers/gpu/drm/radeon/radeon_gem.c | 2 +-
> drivers/gpu/drm/radeon/radeon_i2c.c | 2 +-
> drivers/gpu/drm/radeon/radeon_ib.c | 2 +-
> drivers/gpu/drm/radeon/radeon_irq_kms.c | 12 ++--
> drivers/gpu/drm/radeon/radeon_kms.c | 8 +--
> drivers/gpu/drm/radeon/radeon_object.c | 2 +-
> drivers/gpu/drm/radeon/radeon_pm.c | 20 +++---
> drivers/gpu/drm/radeon/radeon_ring.c | 2 +-
> drivers/gpu/drm/radeon/radeon_ttm.c | 6 +-
> drivers/gpu/drm/radeon/rs400.c | 6 +-
> drivers/gpu/drm/radeon/rs600.c | 14 ++--
> drivers/gpu/drm/radeon/rs690.c | 2 +-
> drivers/gpu/drm/radeon/rv515.c | 4 +-
> drivers/gpu/drm/radeon/rv770.c | 2 +-
> drivers/gpu/drm/radeon/si.c | 4 +-
> 39 files changed, 184 insertions(+), 179 deletions(-)
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
Powered by blists - more mailing lists