linux-kernel - Re: [PATCH v5 0/7] ATA PASS-THROUGH sense data fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171999817621.664489.10486098477695023316.b4-ty@kernel.org>
Date: Wed, 03 Jul 2024 11:16:16 +0200
From: Niklas Cassel <cassel@...nel.org>
To: Damien Le Moal <dlemoal@...nel.org>, Igor Pylypiv <ipylypiv@...gle.com>
Cc: Tejun Heo <tj@...nel.org>, Hannes Reinecke <hare@...e.de>, 
 linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/7] ATA PASS-THROUGH sense data fixes

On Tue, 02 Jul 2024 02:47:28 +0000, Igor Pylypiv wrote:
> This patch series is fixing a few ATA PASS-THROUGH issues:
> 1. Not reporting "ATA Status Return sense data descriptor" / "Fixed format
>    sense data" when ATA_QCFLAG_SENSE_VALID is set.
> 2. Generating "fake" sk/asc/ascq based on ATA status/error registers when
>    ATA_QCFLAG_SENSE_VALID is set and CK_COND=1.
> 3. Fixed format sense data was using incorrect field offsets for ATA
>    PASS-THROUGH commands.
> 4. Using qc->result_tf in ATA sense data generation functions without
>    checking if qc->result_tf contains a valid data.
> 
> [...]

Applied to libata/linux.git (for-6.11), thanks!

[1/7] ata: libata-scsi: Fix offsets for the fixed format sense data
      https://git.kernel.org/libata/linux/c/38dab832
[2/7] ata: libata-scsi: Do not overwrite valid sense data when CK_COND=1
      https://git.kernel.org/libata/linux/c/97981926
[3/7] ata: libata-scsi: Honor the D_SENSE bit for CK_COND=1 and no error
      https://git.kernel.org/libata/linux/c/28ab9769
[4/7] ata: libata-scsi: Remove redundant sense_buffer memsets
      https://git.kernel.org/libata/linux/c/3f6d903b
[5/7] ata: libata-scsi: Do not pass ATA device id to ata_to_sense_error()
      https://git.kernel.org/libata/linux/c/ea3b26a9
[6/7] ata: libata-core: Set ATA_QCFLAG_RTF_FILLED in fill_result_tf()
      https://git.kernel.org/libata/linux/c/18676c6a
[7/7] ata: libata-scsi: Check ATA_QCFLAG_RTF_FILLED before using result_tf
      https://git.kernel.org/libata/linux/c/816be86c

Kind regards,
Niklas