linux-kernel - Re: [PATCH 2/3] modpost: .meminit.* is not in init section when CONFIG_MEMORY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240702185230.9ff500bf6a89db888207f8f1@linux-foundation.org>
Date: Tue, 2 Jul 2024 18:52:30 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Wei Yang <richard.weiyang@...il.com>
Cc: masahiroy@...nel.org, nathan@...nel.org, nicolas@...sle.eu,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 linux-kbuild@...r.kernel.org, Mike Rapoport <rppt@...nel.org>
Subject: Re: [PATCH 2/3] modpost: .meminit.* is not in init section when
 CONFIG_MEMORY_HOTPLUG set

On Tue,  2 Jul 2024 23:40:07 +0000 Wei Yang <richard.weiyang@...il.com> wrote:

> .meminit.* is not put into init section when CONFIG_MEMORY_HOTPLUG is
> set, since we define MEM_KEEP()/MEM_DISCARD() according to
> CONFIG_MEMORY_HOTPLUG.

Please describe how this changes modpost behaviour.

Something like: "we're currently not checking for references into
meminit and meminitdata when CONFIG_HOTPLUG=y, which may cause us to
fail to notice incorrect references.".  But I don't think that's
correct.  So what *is* wrong with the current code?