| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d81740ba-0b15-4f9f-be75-9958ed9f032c@quicinc.com>
Date: Wed, 3 Jul 2024 17:24:36 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, <andersson@...nel.org>,
<konrad.dybcio@...aro.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
<conor+dt@...nel.org>, <djakov@...nel.org>, <mturquette@...libre.com>,
<sboyd@...nel.org>, <jassisinghbrar@...il.com>,
<herbert@...dor.apana.org.au>, <davem@...emloft.net>,
<manivannan.sadhasivam@...aro.org>, <will@...nel.org>,
<joro@...tes.org>, <conor@...nel.org>, <tglx@...utronix.de>,
<amitk@...nel.org>, <thara.gopinath@...il.com>,
<linus.walleij@...aro.org>, <wim@...ux-watchdog.org>,
<linux@...ck-us.net>, <rafael@...nel.org>, <viresh.kumar@...aro.org>,
<vkoul@...nel.org>, <edumazet@...gle.com>, <kuba@...nel.org>,
<pabeni@...hat.com>, <mcoquelin.stm32@...il.com>
CC: <robimarko@...il.com>, <bartosz.golaszewski@...aro.org>,
<kishon@...nel.org>, <quic_wcheng@...cinc.com>,
<alim.akhtar@...sung.com>, <avri.altman@....com>, <bvanassche@....org>,
<agross@...nel.org>, <gregkh@...uxfoundation.org>,
<quic_tdas@...cinc.com>, <robin.murphy@....com>,
<daniel.lezcano@...aro.org>, <rui.zhang@...el.com>,
<lukasz.luba@....com>, <quic_rjendra@...cinc.com>,
<ulf.hansson@...aro.org>, <quic_sibis@...cinc.com>,
<otto.pflueger@...cue.de>, <luca@...tu.xyz>,
<neil.armstrong@...aro.org>, <abel.vesa@...aro.org>,
<bhupesh.sharma@...aro.org>, <alexandre.torgue@...s.st.com>,
<peppe.cavallaro@...com>, <joabreu@...opsys.com>,
<netdev@...r.kernel.org>, <lpieralisi@...nel.org>, <kw@...ux.com>,
<bhelgaas@...gle.com>, <ahalaney@...hat.com>,
<krzysztof.kozlowski@...aro.org>, <u.kleine-koenig@...gutronix.de>,
<dmitry.baryshkov@...aro.org>, <quic_cang@...cinc.com>,
<danila@...xyga.com>, <quic_nitirawa@...cinc.com>,
<mantas@...vices.com>, <athierry@...hat.com>,
<quic_kbajaj@...cinc.com>, <quic_bjorande@...cinc.com>,
<quic_msarkar@...cinc.com>, <quic_devipriy@...cinc.com>,
<quic_tsoni@...cinc.com>, <quic_rgottimu@...cinc.com>,
<quic_shashim@...cinc.com>, <quic_kaushalk@...cinc.com>,
<quic_tingweiz@...cinc.com>, <quic_aiquny@...cinc.com>,
<srinivas.kandagatla@...aro.org>, <linux-arm-msm@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-pm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
<linux-phy@...ts.infradead.org>, <linux-crypto@...r.kernel.org>,
<linux-scsi@...r.kernel.org>, <linux-usb@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <iommu@...ts.linux.dev>,
<linux-riscv@...ts.infradead.org>, <linux-gpio@...r.kernel.org>,
<linux-watchdog@...r.kernel.org>, <linux-pci@...r.kernel.org>,
<linux-stm32@...md-mailman.stormreply.com>, <kernel@...cinc.com>
Subject: Re: [PATCH 04/47] arm64: dts: qcom: qcs9100: Add QCS9100 RIDE board
dts
On 7/3/2024 12:39 PM, Krzysztof Kozlowski wrote:
> On 03/07/2024 04:58, Tengfei Fan wrote:
>> Add support for the QCS9100 RIDE board dts. The current QCS9100 RIDE
>> board dts is directly renamed from the SA8775p RIDE board dts.
>> The difference between the current QCS9100 RIDE board and the SA8775p
>> RIDE board lies solely in the replacement of the SA8775p SoC with the
>> QCS9100 SoC, all other board resources remain the same.
>> The following items have been updated:
>> - use QCS9100-related compatible names for this board dts.
>> - replace the inclusion of sa8775p.dtsi with qcs9100.dtsi.
>> - replace the inclusion of sa8775p-pmics.dtsi with qcs9100-pmics.dtsi
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 2 +-
>> .../boot/dts/qcom/{sa8775p-ride.dts => qcs9100-ride.dts} | 8 ++++----
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>> rename arch/arm64/boot/dts/qcom/{sa8775p-ride.dts => qcs9100-ride.dts} (99%)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index 5576c7d6ea06..a7a3792b0691 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -103,6 +103,7 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb
>> +dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qrb2210-rb1.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qrb4210-rb2.dtb
>> @@ -112,7 +113,6 @@ dtb-$(CONFIG_ARCH_QCOM) += qru1000-idp.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sa8295p-adp.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sa8540p-ride.dtb
>> -dtb-$(CONFIG_ARCH_QCOM) += sa8775p-ride.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sc7180-acer-aspire1.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride.dts
>> similarity index 99%
>> rename from arch/arm64/boot/dts/qcom/sa8775p-ride.dts
>> rename to arch/arm64/boot/dts/qcom/qcs9100-ride.dts
>> index 26ad05bd3b3f..2415d34b8aa5 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs9100-ride.dts
>> @@ -8,12 +8,12 @@
>> #include <dt-bindings/gpio/gpio.h>
>> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>
>> -#include "sa8775p.dtsi"
>> -#include "sa8775p-pmics.dtsi"
>> +#include "qcs9100.dtsi"
>> +#include "qcs9100-pmics.dtsi"
>>
>> / {
>> - model = "Qualcomm SA8775P Ride";
>> - compatible = "qcom,sa8775p-ride", "qcom,sa8775p";
>> + model = "Qualcomm QCS9100 Ride";
>> + compatible = "qcom,qcs9100-ride", "qcom,qcs9100";
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> Your own internal guideline tells you to perform above tests, doesn't it?
>
> Best regards,
> Krzysztof
>
I have performed relevant check, and it's possible that there are some
issues about the parameters used. I will follow your advice and refer to
the relevant documentation to perform DTBS check again, ensuring that
similar issues do not arise in the future.
--
Thx and BRs,
Tengfei Fan
Powered by blists - more mailing lists