linux-kernel - Re: [RESEND. PATCH] nvme/pci: Add APST quirk for Lenovo N60z laptop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A929246EF5D140F2+6a40266f-73c2-4ec3-9667-3503ed1ff3a8@uniontech.com>
Date: Wed, 3 Jul 2024 18:03:58 +0800
From: WangYuli <wangyuli@...ontech.com>
To: Keith Busch <kbusch@...nel.org>
Cc: guanwentao@...ontech.com, huanglin@...ontech.com, axboe@...com,
 hch@....de, sagi@...mberg.me, linux-nvme@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RESEND. PATCH] nvme/pci: Add APST quirk for Lenovo N60z laptop

On 2024/6/25 05:49, Keith Busch wrote:
> Based on your commit message, it sounds like the platform works the
> majority of the time. Is it possible that NVME_QUIRK_NO_DEEPEST_PS is
> sufficient for this? Or do you really need to disable it entirely? The
> power usage differences can be meaningful.
>
> Also, 30 minutes of idle is an eternity for APST to kick in, so I'm
> curious if there's something else going on here or if the breakage
> occurs earlier than that.
>
When we "quiesce" a machine, some applications may not stop disk I/O 
promptly,
so the 30 minutes include the time to wait for these background 
processes to quiet down.

Thanks for the reminder. I've tested it and 'NVME_QUIRK_NO_DEEPEST_PS' 
is effective and
more appropriate than 'NVME_QUIRK_NO_APST'. I'll send a patch v2 to 
update my code.

-- 
WangYuli <wangyuli@...ontech.com>