linux-kernel - Re: [PATCH v1 1/1] KVM: s390: remove useless include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172000224247.95833.192495937410933992@t14-nrb>
Date: Wed, 03 Jul 2024 12:24:02 +0200
From: Nico Boehr <nrb@...ux.ibm.com>
To: Claudio Imbrenda <imbrenda@...ux.ibm.com>, kvm@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        frankja@...ux.ibm.com, borntraeger@...ibm.com, nsg@...ux.ibm.com,
        seiden@...ux.ibm.com, david@...hat.com
Subject: Re: [PATCH v1 1/1] KVM: s390: remove useless include

Quoting Claudio Imbrenda (2024-07-02 17:56:06)
> arch/s390/include/asm/kvm_host.h includes linux/kvm_host.h, but
> linux/kvm_host.h includes asm/kvm_host.h .
> 
> It turns out that arch/s390/include/asm/kvm_host.h only needs
> linux/kvm_types.h, which it already includes.
> 
> Stop including linux/kvm_host.h from arch/s390/include/asm/kvm_host.h .
> 
> Due to the #ifdef guards, the code works as it is today, but it's ugly
> and it will get in the way of future patches.
> 
> Signed-off-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>

Reviewed-by: Nico Boehr <nrb@...ux.ibm.com>