linux-kernel - Re: [PATCH 09/10] clk: sunxi-ng r40: Constify struct regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240703121750.0dc2eb3a@donnerap.manchester.arm.com>
Date: Wed, 3 Jul 2024 12:17:50 +0100
From: Andre Przywara <andre.przywara@....com>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Jerome Brunet
 <jbrunet@...libre.com>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Kevin Hilman <khilman@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Vladimir
 Zapolskiy <vz@...ia.com>, Bjorn Andersson <andersson@...nel.org>, Chen-Yu
 Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel
 Holland <samuel@...lland.org>, Michal Simek <michal.simek@....com>,
 linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH 09/10] clk: sunxi-ng r40: Constify struct regmap_config

On Wed, 03 Jul 2024 11:50:22 +0200
Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:

> `sun8i_r40_ccu_regmap_config` is not modified and can be declared as
> const to move its data to a read-only section.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

Looks alright, we indeed don't change it, and the only user takes a const
pointer. Also the compiler seems happy.

Reviewed-by: Andre Przywara <andre.przywara@....com>

Cheers,
Andre

> ---
>  drivers/clk/sunxi-ng/ccu-sun8i-r40.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-r40.c b/drivers/clk/sunxi-ng/ccu-sun8i-r40.c
> index 984ad3f76b18..2f51ceab8016 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun8i-r40.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun8i-r40.c
> @@ -1292,7 +1292,7 @@ static bool sun8i_r40_ccu_regmap_accessible_reg(struct device *dev,
>  	return false;
>  }
>  
> -static struct regmap_config sun8i_r40_ccu_regmap_config = {
> +static const struct regmap_config sun8i_r40_ccu_regmap_config = {
>  	.reg_bits	= 32,
>  	.val_bits	= 32,
>  	.reg_stride	= 4,
>