linux-kernel - Re: [PATCH 17/20] ASoC: arizona: convert to of_property_for_each_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0796b481-3eec-4618-b92e-a372b7da5381@opensource.cirrus.com>
Date: Wed, 3 Jul 2024 12:31:28 +0100
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>,
        Miguel Ojeda
	<ojeda@...nel.org>, Rob Herring <robh@...nel.org>,
        Saravana Kannan
	<saravanak@...gle.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Michael
 Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, Tony
 Lindgren <tony@...mide.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Emilio López <emilio@...pez.com.ar>,
        Chen-Yu Tsai
	<wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland
	<samuel@...lland.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Daniel Lezcano
	<daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Florian
 Fainelli <florian.fainelli@...adcom.com>,
        Broadcom internal kernel review
 list <bcm-kernel-feedback-list@...adcom.com>,
        Linus Walleij
	<linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Jonathan
 Cameron <jic23@...nel.org>, Lee Jones <lee@...nel.org>,
        Shawn Guo
	<shawnguo@...nel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Uwe Kleine-König <ukleinek@...nel.org>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Richard
 Leitner <richard.leitner@...ux.dev>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        "Naveen N. Rao"
	<naveen.n.rao@...ux.ibm.com>,
        Damien Le Moal <dlemoal@...nel.org>
CC: "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        Thomas Petazzoni
	<thomas.petazzoni@...tlin.com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <llvm@...ts.linux.dev>, <linux-clk@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-sunxi@...ts.linux.dev>,
        <linux-samsung-soc@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <linux-iio@...r.kernel.org>, <linux-pwm@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <patches@...nsource.cirrus.com>, <linux-sound@...r.kernel.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH 17/20] ASoC: arizona: convert to
 of_property_for_each_u32_new()

On 03/07/2024 11:37, Luca Ceresoli wrote:
> Simplify code using of_property_for_each_u32_new() as the two additional
> parameters in of_property_for_each_u32() are not used here.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> ---
>   sound/soc/codecs/arizona.c | 12 +++++-------
>   1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/sound/soc/codecs/arizona.c b/sound/soc/codecs/arizona.c
> index 7434aeeda292..1a64b9815809 100644
> --- a/sound/soc/codecs/arizona.c
> +++ b/sound/soc/codecs/arizona.c
> @@ -2786,15 +2786,13 @@ int arizona_of_get_audio_pdata(struct arizona *arizona)
>   {
>   	struct arizona_pdata *pdata = &arizona->pdata;
>   	struct device_node *np = arizona->dev->of_node;
> -	struct property *prop;
> -	const __be32 *cur;
>   	u32 val;
>   	u32 pdm_val[ARIZONA_MAX_PDM_SPK];
>   	int ret;
>   	int count = 0;
>   
>   	count = 0;
> -	of_property_for_each_u32(np, "wlf,inmode", prop, cur, val) {
> +	of_property_for_each_u32_new(np, "wlf,inmode", val) {
>   		if (count == ARRAY_SIZE(pdata->inmode))
>   			break;
>   
> @@ -2803,7 +2801,7 @@ int arizona_of_get_audio_pdata(struct arizona *arizona)
>   	}
>   
>   	count = 0;
> -	of_property_for_each_u32(np, "wlf,dmic-ref", prop, cur, val) {
> +	of_property_for_each_u32_new(np, "wlf,dmic-ref", val) {
>   		if (count == ARRAY_SIZE(pdata->dmic_ref))
>   			break;
>   
> @@ -2812,7 +2810,7 @@ int arizona_of_get_audio_pdata(struct arizona *arizona)
>   	}
>   
>   	count = 0;
> -	of_property_for_each_u32(np, "wlf,out-mono", prop, cur, val) {
> +	of_property_for_each_u32_new(np, "wlf,out-mono", val) {
>   		if (count == ARRAY_SIZE(pdata->out_mono))
>   			break;
>   
> @@ -2821,7 +2819,7 @@ int arizona_of_get_audio_pdata(struct arizona *arizona)
>   	}
>   
>   	count = 0;
> -	of_property_for_each_u32(np, "wlf,max-channels-clocked", prop, cur, val) {
> +	of_property_for_each_u32_new(np, "wlf,max-channels-clocked", val) {
>   		if (count == ARRAY_SIZE(pdata->max_channels_clocked))
>   			break;
>   
> @@ -2830,7 +2828,7 @@ int arizona_of_get_audio_pdata(struct arizona *arizona)
>   	}
>   
>   	count = 0;
> -	of_property_for_each_u32(np, "wlf,out-volume-limit", prop, cur, val) {
> +	of_property_for_each_u32_new(np, "wlf,out-volume-limit", val) {
>   		if (count == ARRAY_SIZE(pdata->out_vol_limit))
>   			break;
>   
> 
Reviewed-by: Richard Fitzgerald <rf@...nsource.cirrus.com>