linux-kernel - Re: [PATCH 19/20] powerpc/xive: convert to of_property_for_each_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ikxmk8q8.fsf@mail.lhotse>
Date: Wed, 03 Jul 2024 21:36:47 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
  linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 19/20] powerpc/xive: convert to
 of_property_for_each_u32_new()

Luca Ceresoli <luca.ceresoli@...tlin.com> writes:
> Simplify code using of_property_for_each_u32_new() as the two additional
> parameters in of_property_for_each_u32() are not used here.
>
> In this case only the 'prop' variable can be removed and not 'reg',
> because 'reg' is used in _previous_ lines of the same function. There
> is no side effect because the of_property_for_each_u32() macro being
> removed would anyway write 'reg' bwfore reading its value, and 'reg'
> is not used in _following_ lines.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> ---
>  arch/powerpc/sysdev/xive/spapr.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)

cheers