linux-kernel - Re: [PATCH 11/20] irqchip/atmel-aic: convert to of_property_for_each_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8cc31a9-d58f-4a4e-98fb-a7ba47bc744e@microchip.com>
Date: Wed, 3 Jul 2024 15:09:07 +0200
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>, Miguel Ojeda
	<ojeda@...nel.org>, Rob Herring <robh@...nel.org>, Saravana Kannan
	<saravanak@...gle.com>, Nathan Chancellor <nathan@...nel.org>, Michael
 Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Tony
 Lindgren <tony@...mide.com>, Bjorn Andersson <andersson@...nel.org>,
	Emilio López <emilio@...pez.com.ar>, Chen-Yu Tsai
	<wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland
	<samuel@...lland.org>, Krzysztof Kozlowski <krzk@...nel.org>, Daniel Lezcano
	<daniel.lezcano@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, Florian
 Fainelli <florian.fainelli@...adcom.com>, Broadcom internal kernel review
 list <bcm-kernel-feedback-list@...adcom.com>, Linus Walleij
	<linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Jonathan
 Cameron <jic23@...nel.org>, Lee Jones <lee@...nel.org>, Shawn Guo
	<shawnguo@...nel.org>, Pengutronix Kernel Team <kernel@...gutronix.de>,
	Uwe Kleine-König <ukleinek@...nel.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, Richard
 Leitner <richard.leitner@...ux.dev>, Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, Michael Ellerman <mpe@...erman.id.au>,
	Nicholas Piggin <npiggin@...il.com>, Christophe Leroy
	<christophe.leroy@...roup.eu>, "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
	Damien Le Moal <dlemoal@...nel.org>
CC: "Peng Fan (OSS)" <peng.fan@....nxp.com>, Thomas Petazzoni
	<thomas.petazzoni@...tlin.com>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <llvm@...ts.linux.dev>,
	<linux-clk@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-sunxi@...ts.linux.dev>, <linux-samsung-soc@...r.kernel.org>,
	<linux-gpio@...r.kernel.org>, <linux-iio@...r.kernel.org>,
	<linux-pwm@...r.kernel.org>, <linux-serial@...r.kernel.org>,
	<linux-usb@...r.kernel.org>, <patches@...nsource.cirrus.com>,
	<linux-sound@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
	<linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH 11/20] irqchip/atmel-aic: convert to
 of_property_for_each_u32_new()

On 03/07/2024 at 12:36, Luca Ceresoli wrote:
> Simplify code using of_property_for_each_u32_new() as the two additional
> parameters in of_property_for_each_u32() are not used here.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>   drivers/irqchip/irq-atmel-aic-common.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-atmel-aic-common.c b/drivers/irqchip/irq-atmel-aic-common.c
> index 072bd227b6c6..543ea249df53 100644
> --- a/drivers/irqchip/irq-atmel-aic-common.c
> +++ b/drivers/irqchip/irq-atmel-aic-common.c
> @@ -111,8 +111,6 @@ static void __init aic_common_ext_irq_of_init(struct irq_domain *domain)
>          struct device_node *node = irq_domain_get_of_node(domain);
>          struct irq_chip_generic *gc;
>          struct aic_chip_data *aic;
> -       struct property *prop;
> -       const __be32 *p;
>          u32 hwirq;
> 
>          gc = irq_get_domain_generic_chip(domain, 0);
> @@ -120,7 +118,7 @@ static void __init aic_common_ext_irq_of_init(struct irq_domain *domain)
>          aic = gc->private;
>          aic->ext_irqs |= 1;
> 
> -       of_property_for_each_u32(node, "atmel,external-irqs", prop, p, hwirq) {
> +       of_property_for_each_u32_new(node, "atmel,external-irqs", hwirq) {
>                  gc = irq_get_domain_generic_chip(domain, hwirq);
>                  if (!gc) {
>                          pr_warn("AIC: external irq %d >= %d skip it\n",
> 
> --
> 2.34.1
>