linux-kernel - Re: [PATCH] gpio: mmio: do not calculate bgpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172001329822.19609.1796927408061216237.b4-ty@linaro.org>
Date: Wed,  3 Jul 2024 15:28:20 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: linux-gpio@...r.kernel.org,
	Shiji Yang <yangshiji66@...look.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Asmaa Mnebhi <asmaa@...dia.com>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	linux-kernel@...r.kernel.org,
	Mark Mentovai <mark@...tovai.com>,
	Jonas Gorski <jonas.gorski@...il.com>,
	Lóránd Horváth <lorand.horvath82@...il.com>
Subject: Re: [PATCH] gpio: mmio: do not calculate bgpio_bits via "ngpios"

From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>


On Tue, 25 Jun 2024 09:19:49 +0800, Shiji Yang wrote:
> bgpio_bits must be aligned with the data bus width. For example, on a
> 32 bit big endian system and we only have 16 GPIOs. If we only assume
> bgpio_bits=16 we can never control the GPIO because the base address
> is the lowest address.
> 
> low address                          high address
> -------------------------------------------------
> |   byte3   |   byte2   |   byte1   |   byte0   |
> -------------------------------------------------
> |    NaN    |    NaN    |  gpio8-15 |  gpio0-7  |
> -------------------------------------------------
> 
> [...]

Applied, thanks!

[1/1] gpio: mmio: do not calculate bgpio_bits via "ngpios"
      commit: f07798d7bb9c46d17d80103fb772fd2c75d47919

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>