linux-kernel - Re: [PATCH wireless] wifi: wilc1000: fix ies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172001460150.3313435.9699200902279507680.kvalo@kernel.org>
Date: Wed,  3 Jul 2024 13:50:03 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Alexis Lothoré <alexis.lothore@...tlin.com>
Cc: linux-wireless@...r.kernel.org, Ajay Singh <ajay.kathat@...rochip.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-kernel@...r.kernel.org, Jozef Hopko <jozef.hopko@...ana.com>,
 Alexis Lothoré <alexis.lothore@...tlin.com>
Subject: Re: [PATCH wireless] wifi: wilc1000: fix ies_len type in connect path

Alexis Lothoré <alexis.lothore@...tlin.com> wrote:

> From: Jozef Hopko <jozef.hopko@...ana.com>
> 
> Commit 205c50306acf ("wifi: wilc1000: fix RCU usage in connect path")
> made sure that the IEs data was manipulated under the relevant RCU section.
> Unfortunately, while doing so, the commit brought a faulty implicit cast
> from int to u8 on the ies_len variable, making the parsing fail to be
> performed correctly if the IEs block is larger than 255 bytes. This failure
> can be observed with Access Points appending a lot of IEs TLVs in their
> beacon frames (reproduced with a Pixel phone acting as an Access Point,
> which brough 273 bytes of IE data in my testing environment).
> 
> Fix IEs parsing by removing this undesired implicit cast.
> 
> Fixes: 205c50306acf ("wifi: wilc1000: fix RCU usage in connect path")
> Signed-off-by: Jozef Hopko <jozef.hopko@...ana.com>
> Signed-off-by: Alexis Lothoré <alexis.lothore@...tlin.com>
> Acked-by: Ajay Singh <ajay.kathat@...rochip.com>

Patch applied to wireless.git, thanks.

39ab8fff6230 wifi: wilc1000: fix ies_len type in connect path

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240701-wilc_fix_ies_data-v1-1-7486cbacf98a@bootlin.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches