linux-kernel - Re: [patch V4 02/21] irqchip: Provide irq-msi-lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871q4ay3vn.ffs@tglx>
Date: Wed, 03 Jul 2024 15:57:48 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
 maz@...nel.org, anna-maria@...utronix.de, shawnguo@...nel.org,
 s.hauer@...gutronix.de, festevam@...il.com, bhelgaas@...gle.com,
 rdunlap@...radead.org, vidyas@...dia.com, ilpo.jarvinen@...ux.intel.com,
 apatel@...tanamicro.com, kevin.tian@...el.com, nipun.gupta@....com,
 den@...inux.co.jp, andrew@...n.ch, gregory.clement@...tlin.com,
 sebastian.hesselbarth@...il.com, gregkh@...uxfoundation.org,
 rafael@...nel.org, alex.williamson@...hat.com, will@...nel.org,
 lorenzo.pieralisi@....com, jgg@...lanox.com, ammarfaizi2@...weeb.org,
 robin.murphy@....com, nm@...com, kristo@...nel.org, vkoul@...nel.org,
 okaya@...nel.org, agross@...nel.org, andersson@...nel.org,
 mark.rutland@....com, shameerali.kolothum.thodi@...wei.com,
 yuzenghui@...wei.com, shivamurthy.shastri@...utronix.de
Subject: Re: [patch V4 02/21] irqchip: Provide irq-msi-lib

On Mon, Jul 01 2024 at 12:18, Lorenzo Pieralisi wrote:
> On Sun, Jun 23, 2024 at 05:18:34PM +0200, Thomas Gleixner wrote:
>> +bool msi_lib_init_dev_msi_info(struct device *dev, struct irq_domain *domain,
>> +			       struct irq_domain *real_parent,
>> +			       struct msi_domain_info *info)
>> +{
>> +	const struct msi_parent_ops *pops = real_parent->msi_parent_ops;
>> +
>> +	/*
>> +	 * MSI parent domain specific settings. For now there is only the
>> +	 * root parent domain, e.g. NEXUS, acting as a MSI parent, but it is
>> +	 * possible to stack MSI parents. See x86 vector -> irq remapping
>> +	 */
>> +	if (domain->bus_token == pops->bus_select_token) {
>> +		if (WARN_ON_ONCE(domain != real_parent))
>> +			return false;
>> +	} else {
>> +		WARN_ON_ONCE(1);
>> +		return false;
>> +	}
>> +
>> +	/* Parent ops available? */
>> +	if (WARN_ON_ONCE(!pops))
>
> We have already dereferenced pops above, we should move this warning
> before we dereference it (ie checked devmsi-arm-v4-2 too - branch same
> comment applies there too).

Oops. Yes.