[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <jdfuvgaty44kg3xm63l765eueoy66qp7yngmf67nxqh5oifuzq@7gbzytqn5cj7>
Date: Thu, 4 Jul 2024 11:03:01 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>, Elliot Berman <quic_eberman@...cinc.com>,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH] firmware: qcom: tzmem: blacklist more platforms for SHM
Bridge
On Thu, Jul 04, 2024 at 02:12:46PM GMT, Dmitry Baryshkov wrote:
> The SHM bridge makes the Qualcomm RB3 and SM8150-HDK reset while probing
> the RMTFS (in qcom_scm_assign_mem()). Blacklist the SHM Bridge on
> corresponding platforms using SoC-level compat string. If later it's
> found that the bad behaviour is limited just to the particular boards
> rather than SoC, the compat strings can be adjusted.
>
> Reported-by: Neil Armstrong <neil.armstrong@...aro.org>
> Fixes: f86c61498a57 ("firmware: qcom: tzmem: enable SHM Bridge support")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
> drivers/firmware/qcom/qcom_tzmem.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/firmware/qcom/qcom_tzmem.c b/drivers/firmware/qcom/qcom_tzmem.c
> index 5d526753183d..c715729f071c 100644
> --- a/drivers/firmware/qcom/qcom_tzmem.c
> +++ b/drivers/firmware/qcom/qcom_tzmem.c
> @@ -78,6 +78,8 @@ static bool qcom_tzmem_using_shm_bridge;
> /* List of machines that are known to not support SHM bridge correctly. */
> static const char *const qcom_tzmem_blacklist[] = {
> "qcom,sc8180x",
> + "qcom,sdm845", /* reset in rmtfs memory assignment */
> + "qcom,sm8150", /* reset in rmtfs memory assignment */
What confidence do we have in that this list is now complete?
As Bartosz says, we booted RB3 successfully with an earlier version of
this series, what changed?
Regards,
Bjorn
> NULL
> };
>
>
> ---
> base-commit: 82e4255305c554b0bb18b7ccf2db86041b4c8b6e
> change-id: 20240704-shmbridge-blacklist-021bd97b8a93
>
> Best regards,
> --
> Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>
Powered by blists - more mailing lists