linux-kernel - Re: [PATCH v5 4/5] dt-bindings: display: panel: Add compatible for starry-er88577

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240704-cacti-bunny-83fc57eebd8b@spud>
Date: Thu, 4 Jul 2024 17:48:01 +0100
From: Conor Dooley <conor@...nel.org>
To: Zhaoxiong Lv <lvzhaoxiong@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, robh@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	airlied@...il.com, daniel@...ll.ch, mripard@...nel.org,
	dianders@...gle.com, hsinyi@...gle.com, awarnecke002@...mail.com,
	quic_jesszhan@...cinc.com, dmitry.baryshkov@...aro.org,
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/5] dt-bindings: display: panel: Add compatible for
 starry-er88577

On Thu, Jul 04, 2024 at 03:29:57PM +0800, Zhaoxiong Lv wrote:
> The starry-er88577 is a 10.1" WXGA TFT-LCD panel. Hence, we 
> add a new compatible with panel specific config.
> 
> Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@...qin.corp-partner.google.com>
> ---
> Changes between V5 and V4:
> -  1. We are compatible with starry-er88577 panels in the boe-th101mb31ig002
> -     driver, so add it to the "boe,th101mb31ig002-28a.yaml".

Are you sure that "compatible" is the right word here? It seems like the
devices are rather similar, but compatible would mean that the driver
would work for both without changes. The driver patch (and the lack of a
fallback compatible here) implies that the panels are not actually
compatible.

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Cheers,
Conor.

> 
> v4: https://lore.kernel.org/all/20240620115245.31540-2-lvzhaoxiong@huaqin.corp-partner.google.com/
> 
> Changes between V4 and V3:
> -  1. Move positions to keep the list sorted.
> 
> v3: https://lore.kernel.org/all/20240614145609.25432-2-lvzhaoxiong@huaqin.corp-partner.google.com/
> 
> Changes between V3 and V2:
> -  1. Separate the Starry bindings from kingdisplay, and add it to panel-simple-dsi.yaml
> 
> v2: https://lore.kernel.org/all/20240601084528.22502-4-lvzhaoxiong@huaqin.corp-partner.google.com/
> 
> Changes between V2 and V1:
> -  1. Add compatible for Starry er88577 in Kingdisplay kd101ne3 dt-bindings.
> ---
>  .../bindings/display/panel/boe,th101mb31ig002-28a.yaml          | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/boe,th101mb31ig002-28a.yaml b/Documentation/devicetree/bindings/display/panel/boe,th101mb31ig002-28a.yaml
> index 32df26cbfeed..2f251703a121 100644
> --- a/Documentation/devicetree/bindings/display/panel/boe,th101mb31ig002-28a.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/boe,th101mb31ig002-28a.yaml
> @@ -17,6 +17,8 @@ properties:
>      enum:
>          # BOE TH101MB31IG002-28A 10.1" WXGA TFT LCD panel
>        - boe,th101mb31ig002-28a
> +        # The Starry-er88577 is a 10.1" WXGA TFT-LCD panel
> +      - starry,er88577
>  
>    reg: true
>    backlight: true
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)