linux-kernel - Re: [PATCH] riscv: vdso: do not strip debugging info for vdso.so.dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23ce05ba-105d-480f-968a-1ecc2e482634@tenstorrent.com>
Date: Thu, 4 Jul 2024 14:29:24 +1000
From: Cyril Bur <cyrilbur@...storrent.com>
To: duchangbin <changbin.du@...wei.com>
Cc: Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] riscv: vdso: do not strip debugging info for vdso.so.dbg



On 4/7/2024 11:57 am, duchangbin wrote:
> Hello,
> Is there any problem with this change? Ping~
> 
> On Tue, Jun 11, 2024 at 12:09:47PM +0800, Changbin Du wrote:
>> The vdso.so.dbg is a debug version of vdso and could be used for debugging
>> purpose. For example, perf-annotate requires debugging info to show source
>> lines. So let's keep its debugging info.
>>
>> Signed-off-by: Changbin Du <changbin.du@...wei.com>

Looks good to me

Reviewed-by: Cyril Bur <cyrilbur@...storrent.com>
>> ---
>>   arch/riscv/kernel/vdso/Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile
>> index f7ef8ad9b550..960feb1526ca 100644
>> --- a/arch/riscv/kernel/vdso/Makefile
>> +++ b/arch/riscv/kernel/vdso/Makefile
>> @@ -45,7 +45,7 @@ $(obj)/vdso.o: $(obj)/vdso.so
>>   # link rule for the .so file, .lds has to be first
>>   $(obj)/vdso.so.dbg: $(obj)/vdso.lds $(obj-vdso) FORCE
>>   	$(call if_changed,vdsold)
>> -LDFLAGS_vdso.so.dbg = -shared -S -soname=linux-vdso.so.1 \
>> +LDFLAGS_vdso.so.dbg = -shared -soname=linux-vdso.so.1 \
>>   	--build-id=sha1 --hash-style=both --eh-frame-hdr
>>   
>>   # strip rule for the .so file
>> -- 
>> 2.34.1
>>
>