linux-kernel - Re: [PATCH v2 4/4] i2c: piix4: Register SPDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mzyik2wq7v72ohuhho75nm775fkgtgpkxq2tlkpx5xhuizfovh@pak6gj2d3fn2>
Date: Thu, 4 Jul 2024 23:45:41 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Guenter Roeck <linux@...ck-us.net>, Jean Delvare <jdelvare@...e.com>, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH v2 4/4] i2c: piix4: Register SPDs

Hi Thomas,

On Sat, Jun 29, 2024 at 09:19:48AM GMT, Thomas Weißschuh wrote:
> On 2024-06-28 16:09:09+0000, Guenter Roeck wrote:
> > On 6/27/24 10:48, Thomas Weißschuh wrote:
> > > The piix4 I2C bus can carry SPDs, register them if present.
> > > Only look on bus 0, as this is where the SPDs seem to be located.
> > > 
> > > Only the first 8 slots are supported. If the system has more,
> > > then these will not be visible.
> > > 
> > > The AUX bus can not be probed as on some platforms it reports all
> > > devices present and all reads return "0".
> > > This would allow the ee1004 to be probed incorrectly.
> > 
> > Was this reported somewhere ? I don't see it happen on any of my systems
> > (of course that doesn't really mean anything).
> 
> It happened on one of the big server systems I tested on.
> 
> > > Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> > 
> > Reviewed-and-tested-by: Guenter Roeck <linux@...ck-us.net>
> 
> Thanks!
> 
> FYI, combined tags are discouraged by
> Documentation/process/maintainer-tip.rst:
> 
>   Please do not use combined tags, e.g. ``Reported-and-tested-by``, as
>   they just complicate automated extraction of tags.
> 
> I'll add the tags in split form to the patch.

No worries, I'll take care of it.

Thanks,
Andi