[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240704225156.GE10099@pendragon.ideasonboard.com>
Date: Fri, 5 Jul 2024 01:51:56 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Conor Dooley <conor@...nel.org>
Cc: Julien Stephan <jstephan@...libre.com>,
Andy Hsieh <andy.hsieh@...iatek.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org,
Phi-bang Nguyen <pnguyen@...libre.com>
Subject: Re: [PATCH v5 2/5] dt-bindings: media: add mediatek ISP3.0 camsv
On Thu, Jul 04, 2024 at 05:29:59PM +0100, Conor Dooley wrote:
> On Thu, Jul 04, 2024 at 03:36:41PM +0200, Julien Stephan wrote:
> > From: Phi-bang Nguyen <pnguyen@...libre.com>
> >
> > This adds the bindings, for the ISP3.0 camsv module embedded in
> > some Mediatek SoC, such as the mt8365
> >
> > Signed-off-by: Phi-bang Nguyen <pnguyen@...libre.com>
> > Link: https://lore.kernel.org/r/20230807094940.329165-4-jstephan@baylibre.com
>
> Another confusing link tag, why is it here?
>
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/clock/mediatek,mt8365-clk.h>
> > + #include <dt-bindings/memory/mediatek,mt8365-larb-port.h>
> > + #include <dt-bindings/power/mediatek,mt8365-power.h>
> > +
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + camsv1: camsv@...50000 {
>
> Didn't Krzysztof already comment about the node name here?
> Additionally, the "camsv1" label doest appear to be used, so should be
> dropped.
You're right about the label, it should be dropped. Regarding the name,
as far as I understand, Krzysztof was fine with specific names when no
generic alternative can be easily found, which I think is the case here.
If my understanding is incorrect, could someone help finding a better
name ?
> > + compatible = "mediatek,mt8365-camsv";
> > + reg = <0 0x15050000 0 0x0040>,
> > + <0 0x15050208 0 0x0020>,
> > + <0 0x15050400 0 0x0100>;
> > + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&camsys CLK_CAM>,
> > + <&camsys CLK_CAMTG>,
> > + <&camsys CLK_CAMSV0>;
> > + clock-names = "cam", "camtg", "camsv";
> > + iommus = <&iommu M4U_PORT_CAM_IMGO>;
> > + power-domains = <&spm MT8365_POWER_DOMAIN_CAM>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port@0 {
> > + reg = <0>;
> > + camsv1_endpoint: endpoint {
> > + remote-endpoint = <&seninf_camsv1_endpoint>;
> > + };
> > + };
> > + };
> > + };
> > + };
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6bd7df1c3e08..9ac8c08ba692 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -14163,6 +14163,7 @@ M: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > M: Julien Stephan <jstephan@...libre.com>
> > M: Andy Hsieh <andy.hsieh@...iatek.com>
> > S: Supported
> > +F: Documentation/devicetree/bindings/media/mediatek,mt8365-camsv.yaml
> > F: Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml
> >
> > MEDIATEK SMI DRIVER
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists