linux-kernel - Re: [PATCH] mm/memory-failure: allow memory allocation from emergency reserves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240704162629.cf750dd1ee58c70d358466f3@linux-foundation.org>
Date: Thu, 4 Jul 2024 16:26:29 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Miaohe Lin <linmiaohe@...wei.com>
Cc: Rui Qi <qirui.001@...edance.com>, <linux-mm@...ck.org>,
 <linux-kernel@...r.kernel.org>, <nao.horiguchi@...il.com>
Subject: Re: [PATCH] mm/memory-failure: allow memory allocation from
 emergency reserves

On Tue, 2 Jul 2024 16:04:02 +0800 Miaohe Lin <linmiaohe@...wei.com> wrote:

> >> Tasks might not be killed even to_kill struct is allocated.
> >>
> >> ...
> >>
> >>> -	raw_hwp = kmalloc(sizeof(struct raw_hwp_page), GFP_ATOMIC);
> >>> +	raw_hwp = kmalloc(sizeof(struct raw_hwp_page), GFP_ATOMIC | __GFP_MEMALLOC);
> >>
> >> In already hardware poisoned code path, raw_hwp can be allocated to store raw page info
> >> without killing anything. So __GFP_MEMALLOC might not be suitable to use.
> >> Or am I miss something?
> > 
> > Yes, I'm doubtful about this patch.  I think that rather than poking at a
> > particular implementation, it would be helpful for us to see a complete
> > description of the issues which were observed, please.  Let's see the
> > bug report and we can discuss fixes later.
> 
> I agree with you, Andrew. Thanks. :)

I dropped the patch.  Please let's proceed as discussed above.