linux-kernel - Re: [PATCH 2/2] vfs: support statx(..., NULL, AT_EMPTY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877ce1ya4b.fsf@oldenburg.str.redhat.com>
Date: Thu, 04 Jul 2024 07:55:16 +0200
From: Florian Weimer <fweimer@...hat.com>
To: Xi Ruoyao <xry111@...111.site>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,  Christian Brauner
 <brauner@...nel.org>,  libc-alpha@...rceware.org,  "Andreas K. Huettel"
 <dilfridge@...too.org>,  Arnd Bergmann <arnd@...db.de>,  Huacai Chen
 <chenhuacai@...nel.org>,  Mateusz Guzik <mjguzik@...il.com>,  Alexander
 Viro <viro@...iv.linux.org.uk>,  Jan Kara <jack@...e.cz>,
  linux-kernel@...r.kernel.org,  linux-fsdevel@...r.kernel.org,
  io-uring@...r.kernel.org,  Jens Axboe <axboe@...nel.dk>,
  loongarch@...ts.linux.dev
Subject: Re: [PATCH 2/2] vfs: support statx(..., NULL, AT_EMPTY_PATH, ...)

* Xi Ruoyao:

> Also some bad news: Glibc has this:
>
> #if (__WORDSIZE == 32 \
>      && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) \
>     || defined STAT_HAS_TIME32 \
>     || (!defined __NR_newfstatat && !defined __NR_fstatat64)
> # define FSTATAT_USE_STATX 1
> #else
> # define FSTATAT_USE_STATX 0
> #endif

These __NR_* constants come from the glibc headers, not the kernel
headers.  In other words, the result of the preprocessor condition does
not depend on the kernel header version.

Thanks,
Florian