linux-kernel - Re: blk_validate_limits validation of block size (was Re: [PATCH v2] null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZoY-x-mtBoLW30yb@infradead.org>
Date: Wed, 3 Jul 2024 23:18:47 -0700
From: Christoph Hellwig <hch@...radead.org>
To: John Garry <john.g.garry@...cle.com>
Cc: Christoph Hellwig <hch@...radead.org>, Keith Busch <kbusch@...nel.org>,
	Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: blk_validate_limits validation of block size (was Re: [PATCH v2]
 null_blk: fix validation of block size)

On Wed, Jul 03, 2024 at 06:28:48PM +0100, John Garry wrote:
> ok, fine. It's a bit unfortunate that blk_validate_block_size() won't be
> internal to the block layer.

It is a completely trivial helper not really exposing any internals.
In theory we could just open code, but with the PAGE_SIZE limit that
people are trying to remove with large block size support that might
actually create more problems than it solves.