linux-kernel - Re: [PATCH v2 0/7] Simplify event handling logic in input core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <csyxz5pcep5hxtliwhbxmzpgbwr4fpo3ckybsvtzuowgij4yym@ql77o4jlfell>
Date: Thu, 4 Jul 2024 08:44:07 +0200
From: Benjamin Tissoires <bentiss@...nel.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-input@...r.kernel.org, Jeff LaBundy <jeff@...undy.com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/7] Simplify event handling logic in input core

On Jul 03 2024, Dmitry Torokhov wrote:
> This series tries to untangle somewhat convoluted logic in the input
> event processing in the input core by realizing that input handler can
> be either a filter, or a handler that handles a single event at a time,
> or a handler that can handle a sequence of events, but should not mix
> the 3 behaviors in one handler. This allows us to reduce both filter
> functionality and single-event handling functionality to batch handling
> and have the main event handling path to only deal with
> input_handle->events() batch method.
> 
> v2: addressed comments from Benjamin:
> 
> - added missing patch to remove evdev->event() implementation
> - allow not specifying any event handling method to satisfy kgdboc
>   handler
> - expanded comment on order of running input handlers when passing
>   events
> - split pre-allocation into 2 patches and moved removal of count check
>   into 3rd patch.

Thanks for the respin.

This series is:
Reviewed-by: Benjamin Tissoires <bentiss@...nel.org>

Cheers,
Benjamin


> 
> Dmitry Torokhov (7):
>   Input: evdev - remove ->event() method
>   Input: make sure input handlers define only one processing method
>   Input: make events() method return number of events processed
>   Input: simplify event handling logic
>   Input: rearrange input_alloc_device() to prepare for preallocating of vals
>   Input: preallocate memory to hold event values
>   Input: do not check number of events in input_pass_values()
> 
>  drivers/input/evdev.c |  16 +--
>  drivers/input/input.c | 230 ++++++++++++++++++++++++++++--------------
>  include/linux/input.h |   7 +-
>  3 files changed, 163 insertions(+), 90 deletions(-)
> 
> -- 
> 2.45.2.803.g4e1b14247a-goog
>