linux-kernel - Re: [PATCH -next] md/raid5: fix spares errors about rcu usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW5_29Y0TCz3bUU_g5QtjdLK7+qu3cYuy9XG1OikpMcZkA@mail.gmail.com>
Date: Thu, 4 Jul 2024 15:06:05 +0800
From: Song Liu <song@...nel.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: yukuai3@...wei.com, linux-raid@...r.kernel.org, 
	linux-kernel@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH -next] md/raid5: fix spares errors about rcu usage

On Sat, Jun 15, 2024 at 4:52 PM Yu Kuai <yukuai1@...weicloud.com> wrote:
>
> From: Yu Kuai <yukuai3@...wei.com>
>
> As commit ad8606702f26 ("md/raid5: remove rcu protection to access rdev
> from conf") explains, rcu protection can be removed, however, there are
> three places left, there won't be any real problems.
>
> drivers/md/raid5.c:8071:24: error: incompatible types in comparison expression (different address spaces):
> drivers/md/raid5.c:8071:24:    struct md_rdev [noderef] __rcu *
> drivers/md/raid5.c:8071:24:    struct md_rdev *
> drivers/md/raid5.c:7569:25: error: incompatible types in comparison expression (different address spaces):
> drivers/md/raid5.c:7569:25:    struct md_rdev [noderef] __rcu *
> drivers/md/raid5.c:7569:25:    struct md_rdev *
> drivers/md/raid5.c:7573:25: error: incompatible types in comparison expression (different address spaces):
> drivers/md/raid5.c:7573:25:    struct md_rdev [noderef] __rcu *
> drivers/md/raid5.c:7573:25:    struct md_rdev *
>
> Fixes: ad8606702f26 ("md/raid5: remove rcu protection to access rdev from conf")
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

Applied to md-6.11. Thanks!

Song