linux-kernel - Re: [PATCH -next] md: don't wait for MD_RECOVERY_NEEDED for HOT_REMOVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW7H3=pLA0PKpGhYxa-W-6fOeJLzCkFMLQsLOOS1KZ3tUQ@mail.gmail.com>
Date: Thu, 4 Jul 2024 15:08:17 +0800
From: Song Liu <song@...nel.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: mateusz.kusiak@...ux.intel.com, mariusz.tkaczyk@...ux.intel.com, 
	nfbrown@...e.de, hare@...e.de, linux-raid@...r.kernel.org, 
	linux-kernel@...r.kernel.org, yukuai3@...wei.com, yi.zhang@...wei.com, 
	yangerkun@...wei.com
Subject: Re: [PATCH -next] md: don't wait for MD_RECOVERY_NEEDED for
 HOT_REMOVE_DISK ioctl

On Thu, Jun 27, 2024 at 7:24 PM Yu Kuai <yukuai1@...weicloud.com> wrote:
>
> From: Yu Kuai <yukuai3@...wei.com>
>
> Commit 90f5f7ad4f38 ("md: Wait for md_check_recovery before attempting
> device removal.") explained in the commit message that failed device
> must be reomoved from the personality first by md_check_recovery(),
> before it can be removed from the array. That's the reason the commit
> add the code to wait for MD_RECOVERY_NEEDED.
>
> However, this is not the case now, because remove_and_add_spares() is
> called directly from hot_remove_disk() from ioctl path, hence failed
> device(marked faulty) can be removed from the personality by ioctl.
>
> On the other hand, the commit introduced a performance problem that
> if MD_RECOVERY_NEEDED is set and the array is not running, ioctl will
> wait for 5s before it can return failure to user.
>
> Since the waiting is not needed now, fix the problem by removing the
> waiting.
>
> Fixes: 90f5f7ad4f38 ("md: Wait for md_check_recovery before attempting device removal.")
> Reported-by: Mateusz Kusiak <mateusz.kusiak@...ux.intel.com>
> Closes: https://lore.kernel.org/all/814ff6ee-47a2-4ba0-963e-cf256ee4ecfa@linux.intel.com/
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

Applied to md-6.11. Thanks!

Song